Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2413103004: Remove third_party/libjingle and update GN targets. (Closed)

Created:
4 years, 2 months ago by kjellander_chromium
Modified:
3 years, 9 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org, fuzzing_chromium.org, jam, mlamouri+watch-content_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove third_party/libjingle and update GN targets. In order to keep actual changes to a minimum, this CL just moves the targets: //third_party/libjingle:libjingle -> //third_party/webrtc_overrides //third_party/libjingle/webrtc:libjingle_webrtc -> //third_party/webrtc_overrides:init_webrtc and updates the paths to the webrtc_overrides sources. References to the old targets are updated to the new ones, with no additional changes. The //third_party/libjingle:libstunprober target is no longer referenced in Chrome (it's been replaced by //third_party/webrtc/p2p:libstunprober) so it was removed. BUG=677948 Review-Url: https://codereview.chromium.org/2413103004 Cr-Commit-Position: refs/heads/master@{#453530} Committed: https://chromium.googlesource.com/chromium/src/+/e3cbd6d64e02369e691f65f791ab99258305243d

Patch Set 1 : Rebased and changed to webrtc_overrides #

Patch Set 2 : Make more dependencies public #

Patch Set 3 : Restored a bunch of include paths #

Patch Set 4 : Rebased #

Patch Set 5 : Simplified targets to make minimal changes #

Patch Set 6 : Rebased and restored one missing dependency #

Patch Set 7 : Rebased #

Patch Set 8 : Rebased #

Patch Set 9 : Rebased #

Patch Set 10 : Fix rebase mistake #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -209 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/tools/service_discovery_sniffer/BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/DEPS View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 4 5 6 7 8 3 chunks +1 line, -2 lines 0 comments Download
M content/renderer/DEPS View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 5 6 7 8 4 chunks +3 lines, -3 lines 0 comments Download
M extensions/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/BUILD.gn View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M jingle/DEPS View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M remoting/BUILD.gn View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/DEPS View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/BUILD.gn View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/BUILD.gn View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/signaling/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M remoting/test/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
D third_party/libjingle/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/libjingle/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/libjingle/README.chromium View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/libjingle/webrtc/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +0 lines, -66 lines 0 comments Download
A + third_party/webrtc_overrides/BUILD.gn View 1 2 3 4 5 6 7 5 chunks +51 lines, -5 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 56 (40 generated)
mbjorge
Does this cleanup the deps enough that the //jingle target could get un-commented-out in the ...
4 years, 1 month ago (2016-11-03 21:57:50 UTC) #11
kjellander_chromium
On 2016/11/03 21:57:50, mbjorge wrote: > Does this cleanup the deps enough that the //jingle ...
4 years, 1 month ago (2016-11-08 05:57:31 UTC) #12
brettw
Looks like the patch doesn't apply any more and all of the buildbot errors have ...
4 years, 1 month ago (2016-11-18 20:35:21 UTC) #14
kjellander_chromium
I realize //third_party/webrtc_overrides is not an ideal long-term location for this, but at least these ...
3 years, 11 months ago (2016-12-29 11:33:10 UTC) #23
kjellander_chromium
Hmm, I can't seem to figure out why this change breaks those Android bots. //content/browser:browser ...
3 years, 11 months ago (2016-12-30 10:36:51 UTC) #27
kjellander_chromium
+tommi: do you have time to look at my last problem here? I'd be nice ...
3 years, 11 months ago (2017-01-03 13:25:11 UTC) #30
brettw
lgtm
3 years, 11 months ago (2017-01-03 21:23:37 UTC) #31
Sergey Ulanov
lgtm
3 years, 9 months ago (2017-02-27 21:21:05 UTC) #32
tommi (sloooow) - chröme
Rs lgtm.... 4 months? Persistence pays off
3 years, 9 months ago (2017-02-27 22:59:27 UTC) #35
kjellander_chromium
On 2017/02/27 22:59:27, tommi (krómíum) wrote: > Rs lgtm.... 4 months? Persistence pays off I ...
3 years, 9 months ago (2017-02-27 23:19:38 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413103004/200001
3 years, 9 months ago (2017-02-28 00:24:47 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/374066)
3 years, 9 months ago (2017-02-28 00:32:25 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413103004/220001
3 years, 9 months ago (2017-02-28 04:31:24 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/219023) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 9 months ago (2017-02-28 04:37:51 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413103004/240001
3 years, 9 months ago (2017-02-28 05:03:24 UTC) #53
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 06:50:30 UTC) #56
Message was sent while issue was closed.
Committed patchset #10 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/e3cbd6d64e02369e691f65f791ab...

Powered by Google App Engine
This is Rietveld 408576698