service worker: Add promise boilerplate for NavigationPreload enable/disable

service worker: Add promise boilerplate for NavigationPreload enable/disable

This is still just boilerplate, no test added.

BUG=649558
Committed: https://crrev.com/ac291a0d10c9c31ca5ad54f6dd0df98cae19a1b1
Cr-Commit-Position: refs/heads/master@{#424999}

[falken, 2016-10-13 07:04:34]

falken@chromium.org changed reviewers:
+ horo@chromium.org

[falken, 2016-10-13 07:04:35]

ptal

[falken, 2016-10-13 07:04:41]

The CQ bit was checked by falken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 07:04:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-10-13 07:36:06]

https://codereview.chromium.org/2413063003/diff/1/content/child/service_worke...
File content/child/service_worker/web_service_worker_registration_impl.cc
(right):

https://codereview.chromium.org/2413063003/diff/1/content/child/service_worke...
content/child/service_worker/web_service_worker_registration_impl.cc:151: //
TODO(falken): Implement this.
std::unique_ptr<WebEnableNavigationPreloadCallbacks> callback(callbacks);

|callbacks| need to be deleted.

https://codereview.chromium.org/2413063003/diff/1/content/child/service_worke...
content/child/service_worker/web_service_worker_registration_impl.cc:157:
WebEnableNavigationPreloadCallbacks* callbacks) {
WebDisableNavigationPreloadCallbacks

https://codereview.chromium.org/2413063003/diff/1/content/child/service_worke...
content/child/service_worker/web_service_worker_registration_impl.cc:158: //
TODO(falken): Implement this.
std::unique_ptr<WebDisableNavigationPreloadCallbacks> callback(callbacks);

|callbacks| need to be deleted.

[falken, 2016-10-13 07:45:56]

good catch

https://codereview.chromium.org/2413063003/diff/1/content/child/service_worke...
File content/child/service_worker/web_service_worker_registration_impl.cc
(right):

https://codereview.chromium.org/2413063003/diff/1/content/child/service_worke...
content/child/service_worker/web_service_worker_registration_impl.cc:151: //
TODO(falken): Implement this.
On 2016/10/13 07:36:06, horo wrote:
> std::unique_ptr<WebEnableNavigationPreloadCallbacks> callback(callbacks);
> 
> |callbacks| need to be deleted.

Done.

https://codereview.chromium.org/2413063003/diff/1/content/child/service_worke...
content/child/service_worker/web_service_worker_registration_impl.cc:157:
WebEnableNavigationPreloadCallbacks* callbacks) {
On 2016/10/13 07:36:06, horo wrote:
> WebDisableNavigationPreloadCallbacks

Done.

https://codereview.chromium.org/2413063003/diff/1/content/child/service_worke...
content/child/service_worker/web_service_worker_registration_impl.cc:158: //
TODO(falken): Implement this.
On 2016/10/13 07:36:06, horo wrote:
> std::unique_ptr<WebDisableNavigationPreloadCallbacks> callback(callbacks);
> 
> |callbacks| need to be deleted.

Done.

[falken, 2016-10-13 07:46:20]

The CQ bit was checked by falken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 07:46:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-10-13 07:48:04]

lgtm

[falken, 2016-10-13 07:48:48]

The CQ bit was unchecked by falken@chromium.org

[falken, 2016-10-13 07:48:50]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2016-10-13 07:48:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[falken, 2016-10-13 07:50:18]

The CQ bit was unchecked by falken@chromium.org

[falken, 2016-10-13 07:54:35]

Oops, didn't actually call disablePreloadNavigation() yet. Done now.

[falken, 2016-10-13 07:54:53]

The CQ bit was checked by falken@chromium.org

[falken, 2016-10-13 07:54:53]

The patchset sent to the CQ was uploaded after l-g-t-m from horo@chromium.org
Link to the patchset: https://codereview.chromium.org/2413063003/#ps60001
(title: "more boilerplate")

[falken, 2016-10-13 07:55:06]

The CQ bit was unchecked by falken@chromium.org

[commit-bot: I haz the power, 2016-10-13 07:55:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[falken, 2016-10-13 07:55:52]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2016-10-13 07:56:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 10:57:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-13 10:59:43]

Description was changed from

==========
service worker: Add promise boilerplate for NavigationPreload enable/disable

This is still just boilerplate, no test added.

BUG=649558
==========

to

==========
service worker: Add promise boilerplate for NavigationPreload enable/disable

This is still just boilerplate, no test added.

BUG=649558

Committed: https://crrev.com/ac291a0d10c9c31ca5ad54f6dd0df98cae19a1b1
Cr-Commit-Position: refs/heads/master@{#424999}
==========

[commit-bot: I haz the power, 2016-10-13 10:59:44]

Patchset 4 (id:??) landed as
https://crrev.com/ac291a0d10c9c31ca5ad54f6dd0df98cae19a1b1
Cr-Commit-Position: refs/heads/master@{#424999}

[nhiroki, 2016-10-13 11:29:12]

nhiroki@chromium.org changed reviewers:
+ nhiroki@chromium.org

[nhiroki, 2016-10-13 11:29:13]

https://codereview.chromium.org/2413063003/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadCallbacks.h
(right):

https://codereview.chromium.org/2413063003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadCallbacks.h:15:
class EnableNavigationPreloadCallbacks final
Why don't you use PromiseCallbackAdapter<void, ServiceWorkerError>? (see
following links)

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/bindings/core/...
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/servic...

https://codereview.chromium.org/2413063003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadCallbacks.h:30:
class DisableNavigationPreloadCallbacks final
ditto.

[falken, 2016-10-14 04:08:50]

https://codereview.chromium.org/2413063003/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadCallbacks.h
(right):

https://codereview.chromium.org/2413063003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadCallbacks.h:15:
class EnableNavigationPreloadCallbacks final
On 2016/10/13 11:29:13, nhiroki wrote:
> Why don't you use PromiseCallbackAdapter<void, ServiceWorkerError>? (see
> following links)
> 
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/bindings/core/...
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/servic...

Yea I considered using PromiseCallbackAdapter but I never really understood it
and it seemed simpler to just write things out. Now having written this out I
can see how it'd be useful to avoid a new file and new classes. I'll consider
using it.