Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp

Issue 2413063003: service worker: Add promise boilerplate for NavigationPreload enable/disable (Closed)
Patch Set: more boilerplate Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp b/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
index d8487b791e81f0f280c486c2bc188f73d888ae50..1b03b42962dbc9bca354814e44a792a3bf420769 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
@@ -4,16 +4,25 @@
#include "modules/serviceworkers/NavigationPreloadManager.h"
+#include "modules/serviceworkers/NavigationPreloadCallbacks.h"
+#include "modules/serviceworkers/ServiceWorkerRegistration.h"
+
namespace blink {
-ScriptPromise NavigationPreloadManager::enable(ScriptState*) {
- NOTIMPLEMENTED();
- return ScriptPromise();
+ScriptPromise NavigationPreloadManager::enable(ScriptState* scriptState) {
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
+ ScriptPromise promise = resolver->promise();
+ m_registration->webRegistration()->enableNavigationPreload(
+ new EnableNavigationPreloadCallbacks(resolver));
+ return promise;
}
-ScriptPromise NavigationPreloadManager::disable(ScriptState*) {
- NOTIMPLEMENTED();
- return ScriptPromise();
+ScriptPromise NavigationPreloadManager::disable(ScriptState* scriptState) {
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
+ ScriptPromise promise = resolver->promise();
+ m_registration->webRegistration()->disableNavigationPreload(
+ new DisableNavigationPreloadCallbacks(resolver));
+ return promise;
}
ScriptPromise NavigationPreloadManager::setHeaderValue(ScriptState*,
@@ -27,6 +36,12 @@ ScriptPromise NavigationPreloadManager::getState(ScriptState*) {
return ScriptPromise();
}
-NavigationPreloadManager::NavigationPreloadManager() {}
+NavigationPreloadManager::NavigationPreloadManager(
+ ServiceWorkerRegistration* registration)
+ : m_registration(registration) {}
+
+DEFINE_TRACE(NavigationPreloadManager) {
+ visitor->trace(m_registration);
+}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698