Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 241303002: Rename WebFrameImpl to WebLocalFrameImpl. (Closed)

Created:
6 years, 8 months ago by dcheng
Modified:
6 years, 8 months ago
CC:
blink-reviews, tzik, eric.carlson_apple.com, apavlov+blink_chromium.org, aandrey+blink_chromium.org, jamesr, caseq+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, philipj_slow, nhiroki, kinuko, eustas+blink_chromium.org, paulirish+reviews_chromium.org, lushnikov+blink_chromium.org, feature-media-reviews_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, groby+blinkspell_chromium.org
Visibility:
Public.

Description

Rename WebFrameImpl to WebLocalFrameImpl. WebFrameImpl is going to be the concrete implementation of WebLocalFrame going forward. A followup patch will introduce its counterpart for remote frames, WebRemoteFrameImpl. BUG=346764 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171986

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix Mac too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+477 lines, -2792 lines) Patch
M Source/web/AssociatedURLLoader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/AssociatedURLLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 14 chunks +15 lines, -15 lines 0 comments Download
M Source/web/ColorChooserUIController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/ContextFeaturesClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/DatabaseClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/EditorClientImpl.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
M Source/web/IndexedDBClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/LinkHighlight.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/LocalFileSystemClient.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/MediaKeysClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/SharedWorkerRepositoryClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/StorageClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/StorageQuotaClientImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/TextFinder.h View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/web/TextFinder.cpp View 12 chunks +16 lines, -16 lines 0 comments Download
M Source/web/WebDOMFileSystem.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebDOMMessageEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentPrivate.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsFrontendImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebDocument.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
D Source/web/WebFrameImpl.h View 1 1 chunk +0 lines, -378 lines 0 comments Download
D Source/web/WebFrameImpl.cpp View 1 1 chunk +0 lines, -1965 lines 0 comments Download
M Source/web/WebHelperPluginImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebHelperPluginImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
A + Source/web/WebLocalFrameImpl.h View 1 10 chunks +31 lines, -28 lines 0 comments Download
A + Source/web/WebLocalFrameImpl.cpp View 1 70 chunks +205 lines, -184 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPageSerializer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebPageSerializerImpl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebPageSerializerImpl.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/web/WebRange.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 15 chunks +18 lines, -18 lines 0 comments Download
M Source/web/WorkerGlobalScopeProxyProviderImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/mac/WebSubstringUtil.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/CompositedLayerMappingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/CustomEventTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/FrameLoaderClientImplTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/FrameTestHelpers.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/tests/LinkHighlightTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/PageSerializerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/PopupMenuTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/ProgrammaticScrollTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/RenderTableCellTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/RenderTableRowTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 26 chunks +33 lines, -33 lines 0 comments Download
M Source/web/tests/WebPluginContainerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebViewTest.cpp View 19 chunks +19 lines, -19 lines 0 comments Download
M Source/web/web.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M public/web/WebFrame.h View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dcheng
More or less just a rename.
6 years, 8 months ago (2014-04-17 18:42:57 UTC) #1
dcheng
+abarth, because I can't seem to find Eric atm.
6 years, 8 months ago (2014-04-18 17:46:53 UTC) #2
eseidel
I support this product and or service. rslgtm.
6 years, 8 months ago (2014-04-18 18:22:19 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 8 months ago (2014-04-18 18:59:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/241303002/10001
6 years, 8 months ago (2014-04-18 18:59:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 19:41:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-18 19:41:10 UTC) #7
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 8 months ago (2014-04-18 22:22:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/241303002/30001
6 years, 8 months ago (2014-04-18 22:22:17 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 23:27:21 UTC) #10
Message was sent while issue was closed. 
Change committed as 171986

Powered by Google App Engine
This is Rietveld 408576698