Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 2412963003: Replace CHROMEOS_SYSLOG logs with SYSLOG logs so remote command related (Closed)

Created:
4 years, 2 months ago by Marton Hunyady
Modified:
4 years, 2 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace CHROMEOS_SYSLOG logs with SYSLOG logs so remote command related logs will get uploaded to the management console even after the kiosk session started. BUG=602572 Committed: https://crrev.com/98991ca7a6c1ea7048f2ecf3246afdde6a1200df Cr-Commit-Position: refs/heads/master@{#425342}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 14 (7 generated)
Marton Hunyady
PTAL Also, should I also remove the whole base/chromeos/logging.h file, or will we use it ...
4 years, 2 months ago (2016-10-13 17:11:48 UTC) #2
Andrew T Wilson (Slow)
LGTM with two notes: 1) We are moving some logs from WARNING to INFO level ...
4 years, 2 months ago (2016-10-14 12:41:14 UTC) #3
Marton Hunyady
On 2016/10/14 12:41:14, Andrew T Wilson (Slow) wrote: > 1) We are moving some logs ...
4 years, 2 months ago (2016-10-14 12:47:47 UTC) #4
Marton Hunyady
https://codereview.chromium.org/2412963003/diff/1/chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc File chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc (right): https://codereview.chromium.org/2412963003/diff/1/chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc#newcode52 chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc:52: SYSLOG(INFO) << "Running reboot command."; On 2016/10/14 12:41:14, Andrew ...
4 years, 2 months ago (2016-10-14 12:47:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412963003/1
4 years, 2 months ago (2016-10-14 16:07:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 16:14:31 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 16:16:26 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98991ca7a6c1ea7048f2ecf3246afdde6a1200df
Cr-Commit-Position: refs/heads/master@{#425342}

Powered by Google App Engine
This is Rietveld 408576698