Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: components/policy/core/common/remote_commands/remote_commands_service.cc

Issue 2412963003: Replace CHROMEOS_SYSLOG logs with SYSLOG logs so remote command related (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/remote_commands/remote_commands_service.cc
diff --git a/components/policy/core/common/remote_commands/remote_commands_service.cc b/components/policy/core/common/remote_commands/remote_commands_service.cc
index 52625b327fecf3582b2b4d0fe4ab37351a52332e..acbf4eced6ccf1e1c173c47f732854ec7a642665 100644
--- a/components/policy/core/common/remote_commands/remote_commands_service.cc
+++ b/components/policy/core/common/remote_commands/remote_commands_service.cc
@@ -9,7 +9,7 @@
#include <utility>
#include "base/bind.h"
-#include "base/chromeos/logging.h"
+#include "base/syslog_logging.h"
#include "base/time/tick_clock.h"
#include "base/time/time.h"
#include "components/policy/core/common/cloud/cloud_policy_client.h"
@@ -33,15 +33,15 @@ RemoteCommandsService::~RemoteCommandsService() {
bool RemoteCommandsService::FetchRemoteCommands() {
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
- CHROMEOS_SYSLOG(WARNING) << "Fetching remote commands.";
+ SYSLOG(INFO) << "Fetching remote commands.";
if (!client_->is_registered()) {
- CHROMEOS_SYSLOG(WARNING) << "Client is not registered.";
+ SYSLOG(WARNING) << "Client is not registered.";
return false;
}
if (command_fetch_in_progress_) {
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
- CHROMEOS_SYSLOG(WARNING) << "Command fetch is already in progress.";
+ SYSLOG(WARNING) << "Command fetch is already in progress.";
has_enqueued_fetch_request_ = true;
return false;
}
@@ -84,7 +84,7 @@ void RemoteCommandsService::SetClockForTesting(
void RemoteCommandsService::EnqueueCommand(
const enterprise_management::RemoteCommand& command) {
if (!command.has_type() || !command.has_unique_id()) {
- CHROMEOS_SYSLOG(ERROR) << "Invalid remote command from server.";
+ SYSLOG(ERROR) << "Invalid remote command from server.";
return;
}
@@ -100,7 +100,7 @@ void RemoteCommandsService::EnqueueCommand(
factory_->BuildJobForType(command.type());
if (!job || !job->Init(queue_.GetNowTicks(), command)) {
- CHROMEOS_SYSLOG(ERROR) << "Initialization of remote command failed.";
+ SYSLOG(ERROR) << "Initialization of remote command failed.";
em::RemoteCommandResult ignored_result;
ignored_result.set_result(
em::RemoteCommandResult_ResultType_RESULT_IGNORED);
@@ -145,8 +145,8 @@ void RemoteCommandsService::OnJobFinished(RemoteCommandJob* command) {
NOTREACHED();
}
- CHROMEOS_SYSLOG(WARNING) << "Remote command " << command->unique_id()
- << " finished with result " << result.result();
+ SYSLOG(INFO) << "Remote command " << command->unique_id()
+ << " finished with result " << result.result();
unsent_results_.push_back(result);
@@ -158,7 +158,7 @@ void RemoteCommandsService::OnRemoteCommandsFetched(
const std::vector<enterprise_management::RemoteCommand>& commands) {
DCHECK(command_fetch_in_progress_);
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
- CHROMEOS_SYSLOG(WARNING) << "Remote commands fetched.";
+ SYSLOG(INFO) << "Remote commands fetched.";
command_fetch_in_progress_ = false;
// TODO(binjin): Add retrying on errors. See http://crbug.com/466572.

Powered by Google App Engine
This is Rietveld 408576698