Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2412923002: Top-align table cells in rows that cross fragmentainer boundaries. (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Top-align table cells in rows that cross fragmentainer boundaries. Ignore whatever vertical-align says and force everything to be top aligned in those cases. Edge also behaves like this. Doing both fragmentation and vertical alignment for table parts could cause unresolvable situations (cyclic dependencies). Two tests that depended on vertical alignment working under such circumstances are now invalid, and were therefore removed. BUG=534751 Committed: https://crrev.com/c2025efb0537e16c304c37b1df4d687ec698cd68 Cr-Commit-Position: refs/heads/master@{#425112}

Patch Set 1 #

Patch Set 2 : Let's keep the pagination strut substraction thing a bit longer, since removing it affects some DRT… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -188 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 2 chunks +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/multicol/cell-shrinkback.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/multicol/cell-shrinkback-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/multicol/table-vertical-align.html View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/multicol/table-vertical-align-expected.html View 1 chunk +0 lines, -71 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/fragmented-table-cell.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/fragmented-table-cell-expected.html View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
mstensho (USE GERRIT)
This is the first CL in a series of CLs whose aim is to make ...
4 years, 2 months ago (2016-10-13 15:05:58 UTC) #11
eae
LGTM
4 years, 2 months ago (2016-10-13 17:32:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412923002/20001
4 years, 2 months ago (2016-10-13 18:47:45 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 18:56:34 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 18:58:46 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2025efb0537e16c304c37b1df4d687ec698cd68
Cr-Commit-Position: refs/heads/master@{#425112}

Powered by Google App Engine
This is Rietveld 408576698