third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2412923002: Top-align table cells in rows that cross fragmentainer boundaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2412923002: Top-align table cells in rows that cross fragmentainer boundaries. (Closed)

Patch Set: Let's keep the pagination strut substraction thing a bit longer, since removing it affects some DRT… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index f1809eda34c3899fbb409c5579a24cc202894627..494a7125230755c693df355743baf377e597eda6 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -5501,6 +5501,14 @@ LayoutUnit LayoutBox::pageRemainingLogicalHeightForOffset(

pageBoundaryRule);

}

+bool LayoutBox::crossesPageBoundary(LayoutUnit offset,

+ LayoutUnit logicalHeight) const {

+ if (!view()->layoutState()->pageLogicalHeight())

+ return false;

+ return pageRemainingLogicalHeightForOffset(offset, AssociateWithLatterPage) <

+ logicalHeight;

LayoutUnit LayoutBox::calculatePaginationStrutToFitContent(

LayoutUnit offset,

LayoutUnit strutToNextPage,