Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2412863005: Make some code gender neutral. (Closed)

Created:
4 years, 2 months ago by benwells
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, kcarattini, Jered
CC:
chromium-reviews, skanuj+watch_chromium.org, sadrul, yusukes+watch_chromium.org, dhollowa+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, extensions-reviews_chromium.org, melevin+watch_chromium.org, chromium-apps-reviews_chromium.org, dougw+watch_chromium.org, jfweitz+watch_chromium.org, oshima+watch_chromium.org, kalyank, elijahtaylor+arcwatch_chromium.org, tfarina, donnd+watch_chromium.org, David Black, samarth+watch_chromium.org, mac-reviews_chromium.org, kmadhusu+watch_chromium.org, davemoore+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make some code gender neutral. This removes language like "his" and "her" from comments and string descriptions. BUG=542537 Committed: https://crrev.com/e3496e19094cf7e711508fe69b197aa13725c790 Cr-Commit-Position: refs/heads/master@{#425448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M chrome/app/generated_resources.grd View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/app/settings_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_navigation_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/proto/chrome_device_policy.proto View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_job_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_screenshot_grabber.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/user_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/platform_keys.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/update_cache.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/safari_importer.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
benwells
Kendra, want to have a look at the first of these patches? Looks like there ...
4 years, 2 months ago (2016-10-14 00:51:26 UTC) #6
benwells
Kendra, want to have a look at the first of these patches? Looks like there ...
4 years, 2 months ago (2016-10-14 00:51:27 UTC) #8
Jered
On 2016/10/14 00:51:27, benwells (slow) wrote: > Kendra, want to have a look at the ...
4 years, 2 months ago (2016-10-14 00:53:55 UTC) #9
kcarattini
lgtm. Thanks so much for getting this started!
4 years, 2 months ago (2016-10-14 04:50:41 UTC) #10
benwells
+thestig for owner review
4 years, 2 months ago (2016-10-14 05:14:54 UTC) #12
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-14 19:23:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412863005/1
4 years, 2 months ago (2016-10-14 19:24:03 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 20:14:51 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e3496e19094cf7e711508fe69b197aa13725c790 Cr-Commit-Position: refs/heads/master@{#425448}
4 years, 2 months ago (2016-10-14 20:18:22 UTC) #18
Thiemo Nagel
4 years, 2 months ago (2016-10-17 10:00:54 UTC) #19
Message was sent while issue was closed.
Thank you Ben for making our codebase more inclusive!

Powered by Google App Engine
This is Rietveld 408576698