Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Side by Side Diff: chrome/browser/chromeos/arc/arc_navigation_throttle.cc

Issue 2412863005: Make some code gender neutral. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/arc/arc_navigation_throttle.h" 5 #include "chrome/browser/chromeos/arc/arc_navigation_throttle.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 // create a throttle. 171 // create a throttle.
172 DVLOG(1) 172 DVLOG(1)
173 << "Chrome browser is selected as the preferred app for this URL: " 173 << "Chrome browser is selected as the preferred app for this URL: "
174 << navigation_handle()->GetURL().spec(); 174 << navigation_handle()->GetURL().spec();
175 } 175 }
176 OnIntentPickerClosed(std::move(handlers), i, 176 OnIntentPickerClosed(std::move(handlers), i,
177 CloseReason::PREFERRED_ACTIVITY_FOUND); 177 CloseReason::PREFERRED_ACTIVITY_FOUND);
178 return; 178 return;
179 } 179 }
180 180
181 // Swap Chrome app with any app in row |kMaxAppResults-1| iff his index is 181 // Swap Chrome app with any app in row |kMaxAppResults-1| iff its index is
182 // bigger, thus ensuring the user can always see Chrome without scrolling. 182 // bigger, thus ensuring the user can always see Chrome without scrolling.
183 size_t chrome_app_index = 0; 183 size_t chrome_app_index = 0;
184 for (size_t i = 0; i < handlers.size(); ++i) { 184 for (size_t i = 0; i < handlers.size(); ++i) {
185 if (ArcIntentHelperBridge::IsIntentHelperPackage( 185 if (ArcIntentHelperBridge::IsIntentHelperPackage(
186 handlers[i]->package_name)) { 186 handlers[i]->package_name)) {
187 chrome_app_index = i; 187 chrome_app_index = i;
188 break; 188 break;
189 } 189 }
190 } 190 }
191 191
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 } 293 }
294 294
295 // static 295 // static
296 bool ArcNavigationThrottle::ShouldOverrideUrlLoadingForTesting( 296 bool ArcNavigationThrottle::ShouldOverrideUrlLoadingForTesting(
297 const GURL& previous_url, 297 const GURL& previous_url,
298 const GURL& current_url) { 298 const GURL& current_url) {
299 return ShouldOverrideUrlLoading(previous_url, current_url); 299 return ShouldOverrideUrlLoading(previous_url, current_url);
300 } 300 }
301 301
302 } // namespace arc 302 } // namespace arc
OLDNEW
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/chromeos/policy/proto/chrome_device_policy.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698