components/app_modal/app_modal_dialog.h - Issue 2412843002: Simplify the JavaScriptDialogManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/app_modal/app_modal_dialog.h

Issue 2412843002: Simplify the JavaScriptDialogManager. (Closed)

Patch Set: braces Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/app_modal/app_modal_dialog.h

diff --git a/components/app_modal/app_modal_dialog.h b/components/app_modal/app_modal_dialog.h

index c4923eaf88aa3bd4c2fcdf1c563a42be506cc5ca..78b4b7e25ffb1d347e42c005bbcc4f3c0b9e9566 100644

--- a/components/app_modal/app_modal_dialog.h

+++ b/components/app_modal/app_modal_dialog.h

@@ -55,7 +55,7 @@ class AppModalDialog {

// Invalidates the dialog, therefore causing it to not be shown when its turn

// to be shown comes around.

- virtual void Invalidate();

+ virtual void Invalidate(bool suppress_callbacks);

// Used only for testing. Returns whether the dialog is a JavaScript modal

// dialog.