Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2412683003: Fix call to WriteDepfile in emma_instr.py. (Closed)

Created:
4 years, 2 months ago by mikecase (-- gone --)
Modified:
4 years, 2 months ago
Reviewers:
agrieve
CC:
agrieve+watch_chromium.org, chromium-reviews, hzl, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, mvanouwerkerk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix call to WriteDepfile in emma_instr.py. This should fix ability to collect Java coverage data. Committed: https://crrev.com/54e5474b559fe6215824be99617463ba27384104 Cr-Commit-Position: refs/heads/master@{#424755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/android/gyp/emma_instr.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mikecase (-- gone --)
Updateing call to WriteDepfile. Looks like it was missed in this CL https://codereview.chromium.org/2336173003 In this ...
4 years, 2 months ago (2016-10-12 14:54:15 UTC) #2
mikecase (-- gone --)
cc mvanouwerkerk@, junit coverage seemed to work for me as described here.... https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/coverage.md ..with this ...
4 years, 2 months ago (2016-10-12 14:55:55 UTC) #3
agrieve
On 2016/10/12 14:54:15, mikecase wrote: > Updateing call to WriteDepfile. Looks like it was missed ...
4 years, 2 months ago (2016-10-12 14:56:24 UTC) #5
Michael van Ouwerkerk
Thanks Mike!
4 years, 2 months ago (2016-10-12 15:14:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412683003/1
4 years, 2 months ago (2016-10-12 16:02:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 16:09:00 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 16:11:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54e5474b559fe6215824be99617463ba27384104
Cr-Commit-Position: refs/heads/master@{#424755}

Powered by Google App Engine
This is Rietveld 408576698