Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2412613004: [stubs] Remove unused StoreGlobalViaContextStub. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Remove unused StoreGlobalViaContextStub. Committed: https://crrev.com/9b5a1cf5d895e5ee563a531ac5ad6bb49ef3b1ed Cr-Commit-Position: refs/heads/master@{#40220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1249 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/code-stubs.h View 2 chunks +0 lines, -28 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -123 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -113 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -113 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -127 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -123 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -123 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL at this nice red-only CL :)
4 years, 2 months ago (2016-10-12 10:24:57 UTC) #4
Jakob Kummerow
Yay! LGTM.
4 years, 2 months ago (2016-10-12 12:08:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412613004/1
4 years, 2 months ago (2016-10-12 13:02:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 13:06:00 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 13:06:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b5a1cf5d895e5ee563a531ac5ad6bb49ef3b1ed
Cr-Commit-Position: refs/heads/master@{#40220}

Powered by Google App Engine
This is Rietveld 408576698