[ic] Support non-code handlers in megamorphic stub cache.

[ic] Support non-code handlers in megamorphic stub cache.

BUG=

Committed: https://crrev.com/c97535f57ed10c53c64c36c1b496d523154b52f7
Cr-Commit-Position: refs/heads/master@{#40255}

[Igor Sheludko, 2016-10-12 12:08:45]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 12:08:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-10-12 12:10:03]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2016-10-12 12:10:03]

PTAL

[commit-bot: I haz the power, 2016-10-12 12:34:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 12:34:55]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-10-12 13:36:08]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 13:36:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-10-12 13:36:27]

Description was changed from

==========
[ic] Support non-code handlers in megamorphic stub cache.
==========

to

==========
[ic] Support non-code handlers in megamorphic stub cache.

BUG=
==========

[commit-bot: I haz the power, 2016-10-12 14:01:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 14:01:09]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2016-10-13 11:14:06]

lgtm

https://codereview.chromium.org/2412043003/diff/10001/src/ic/ic.cc
File src/ic/ic.cc (left):

https://codereview.chromium.org/2412043003/diff/10001/src/ic/ic.cc#oldcode973
src/ic/ic.cc:973: FieldIndex::ForLoadByFieldOffset(map,
Smi::cast(code)->value());
FieldIndex::ForLoadByFieldOffset is now unused. Wanna delete it too?

https://codereview.chromium.org/2412043003/diff/10001/src/type-feedback-vecto...
File src/type-feedback-vector.cc (right):

https://codereview.chromium.org/2412043003/diff/10001/src/type-feedback-vecto...
src/type-feedback-vector.cc:10: #include "src/ic/ic.h"
nit: you can drop foo.h when you #include foo-inl.h

[Igor Sheludko, 2016-10-13 11:35:52]

https://codereview.chromium.org/2412043003/diff/10001/src/ic/ic.cc
File src/ic/ic.cc (left):

https://codereview.chromium.org/2412043003/diff/10001/src/ic/ic.cc#oldcode973
src/ic/ic.cc:973: FieldIndex::ForLoadByFieldOffset(map,
Smi::cast(code)->value());
On 2016/10/13 11:14:06, Jakob Kummerow wrote:
> FieldIndex::ForLoadByFieldOffset is now unused. Wanna delete it too?

Done.

https://codereview.chromium.org/2412043003/diff/10001/src/type-feedback-vecto...
File src/type-feedback-vector.cc (right):

https://codereview.chromium.org/2412043003/diff/10001/src/type-feedback-vecto...
src/type-feedback-vector.cc:10: #include "src/ic/ic.h"
On 2016/10/13 11:14:06, Jakob Kummerow wrote:
> nit: you can drop foo.h when you #include foo-inl.h

Done.

[Igor Sheludko, 2016-10-13 11:35:58]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 11:36:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-10-13 11:43:40]

The CQ bit was unchecked by ishell@chromium.org

[Igor Sheludko, 2016-10-13 11:43:44]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-10-13 11:43:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2412043003/#ps30001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-10-13 11:43:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 12:02:09]

Description was changed from

==========
[ic] Support non-code handlers in megamorphic stub cache.

BUG=
==========

to

==========
[ic] Support non-code handlers in megamorphic stub cache.

BUG=
==========

[commit-bot: I haz the power, 2016-10-13 12:02:10]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-10-13 12:02:33]

Description was changed from

==========
[ic] Support non-code handlers in megamorphic stub cache.

BUG=
==========

to

==========
[ic] Support non-code handlers in megamorphic stub cache.

BUG=

Committed: https://crrev.com/c97535f57ed10c53c64c36c1b496d523154b52f7
Cr-Commit-Position: refs/heads/master@{#40255}
==========

[commit-bot: I haz the power, 2016-10-13 12:02:33]

Patchset 3 (id:??) landed as
https://crrev.com/c97535f57ed10c53c64c36c1b496d523154b52f7
Cr-Commit-Position: refs/heads/master@{#40255}