Use CreateProcess instead of subprocess.Popen to launch Chrome in the mini_installer test framework.

chrome/test/mini_installer/test_installer.py

Index: chrome/test/mini_installer/test_installer.py
diff --git a/chrome/test/mini_installer/test_installer.py b/chrome/test/mini_installer/test_installer.py
index e0614243b0ee51d3c5219d77e050f43e494f4bb3..866f6e7810a91a03d00e57067c6ca024b9262384 100644
--- a/chrome/test/mini_installer/test_installer.py
+++ b/chrome/test/mini_installer/test_installer.py
@@ -200,6 +200,13 @@ def RunTests(mini_installer_path, config):
   for test in config.tests:
     suite.addTest(InstallerTest(test, config, path_resolver))
   result = unittest.TextTestRunner(verbosity=2).run(suite)
+
+  # We want to terminate all child processes that were spawned during the tests.
+  # One way to do this is to put them in a job object. However, Chrome also uses
+  # a job object and the ability to use nested jobs was only added in Windows 8.
+  # Work around this by using taskkill.
+  subprocess.call('taskkill /f /im chrome.exe', shell=True)

[gab, 2013/09/13 21:16:10]

If the intention is to exit cleanly, would it make more sense to call
_RunCleanCommand() from here instead of doing a kill of chrome.exe (which is
kind of arbitrary cleaning since it doesn't clean everything anyways)?

+
   return result.wasSuccessful()