Use CreateProcess instead of subprocess.Popen to launch Chrome in the mini_installer test framework.

chrome/test/mini_installer/test_installer.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """This script tests the installer with test cases specified in the config file.
 
 For each test case, it checks that the machine states after the execution of
 each command match the expected machine states. For more details, take a look at
 the design documentation at http://goo.gl/Q0rGM6
 """
@@ skipping 182 matching lines @@
     config: A Config object.
 
   Returns:
     True if all the tests passed, or False otherwise.
   """
   suite = unittest.TestSuite()
   path_resolver = PathResolver(mini_installer_path)
   for test in config.tests:
     suite.addTest(InstallerTest(test, config, path_resolver))
   result = unittest.TextTestRunner(verbosity=2).run(suite)
+
+  # We want to terminate all child processes that were spawned during the tests.
+  # One way to do this is to put them in a job object. However, Chrome also uses
+  # a job object and the ability to use nested jobs was only added in Windows 8.
+  # Work around this by using taskkill.
+  subprocess.call('taskkill /f /im chrome.exe', shell=True)

[gab, 2013/09/13 21:16:10]

If the intention is to exit cleanly, would it make more sense to call
_RunCleanCommand() from here instead of doing a kill of chrome.exe (which is
kind of arbitrary cleaning since it doesn't clean everything anyways)?

+
   return result.wasSuccessful()
 
 
 def main():
   usage = 'usage: %prog [options] config_filename'
   parser = optparse.OptionParser(usage, description='Test the installer.')
   parser.add_option('--build-dir', default='out',
                     help='Path to main build directory (the parent of the '
                          'Release or Debug directory)')
   parser.add_option('--target', default='Release',
                     help='Build target (Release or Debug)')
   options, args = parser.parse_args()
   if len(args) != 1:
     parser.error('Incorrect number of arguments.')
   config_filename = args[0]
 
   mini_installer_path = os.path.join(options.build_dir, options.target,
                                      'mini_installer.exe')
   assert os.path.exists(mini_installer_path), ('Could not find file %s' %
                                                mini_installer_path)
   config = ParseConfigFile(config_filename)
   if not RunTests(mini_installer_path, config):
     return 1
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())