relnote: Add a new RstStreamErrorCode for resetting streams due to push stream is unclaimed and tim…

relnote: Add a new RstStreamErrorCode for resetting streams due to push stream is unclaimed and times out. Flag protected by quic_send_push_stream_timed_out_error, default on.

Merge internal change: 135855149

BUG=232040
Committed: https://crrev.com/e3e4bdd8b41ecb5a6ed5564cafe40bebbcbe1d47
Cr-Commit-Position: refs/heads/master@{#424886}

[Zhongyi Shi, 2016-10-12 02:52:31]

zhongyi@chromium.org changed reviewers:
+ rch@chromium.org

[Zhongyi Shi, 2016-10-12 02:52:32]

This is used to collect how often push promise times out in QUIC.

[Ryan Hamilton, 2016-10-12 03:57:40]

lgtm

https://codereview.chromium.org/2412483004/diff/1/net/quic/core/quic_flags_li...
File net/quic/core/quic_flags_list.h (right):

https://codereview.chromium.org/2412483004/diff/1/net/quic/core/quic_flags_li...
net/quic/core/quic_flags_list.h:160: QUIC_FLAG(bool,
FLAGS_quic_send_push_stream_timed_out_error, true)
Just to confirm, this is enabled by default internally?

[Zhongyi Shi, 2016-10-12 21:15:12]

On 2016/10/12 03:57:40, Ryan Hamilton wrote:
> lgtm
> 
>
https://codereview.chromium.org/2412483004/diff/1/net/quic/core/quic_flags_li...
> File net/quic/core/quic_flags_list.h (right):
> 
>
https://codereview.chromium.org/2412483004/diff/1/net/quic/core/quic_flags_li...
> net/quic/core/quic_flags_list.h:160: QUIC_FLAG(bool,
> FLAGS_quic_send_push_stream_timed_out_error, true)
> Just to confirm, this is enabled by default internally?

Yeah, the internal is also default on.

[Zhongyi Shi, 2016-10-12 21:17:21]

The CQ bit was checked by zhongyi@chromium.org

[commit-bot: I haz the power, 2016-10-12 21:18:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 22:35:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-12 22:37:59]

Description was changed from

==========
relnote: Add a new RstStreamErrorCode for resetting streams due to push stream
is unclaimed and times out. Flag protected by
quic_send_push_stream_timed_out_error, default on.

Merge internal change: 135855149

BUG=232040
==========

to

==========
relnote: Add a new RstStreamErrorCode for resetting streams due to push stream
is unclaimed and times out. Flag protected by
quic_send_push_stream_timed_out_error, default on.

Merge internal change: 135855149

BUG=232040

Committed: https://crrev.com/e3e4bdd8b41ecb5a6ed5564cafe40bebbcbe1d47
Cr-Commit-Position: refs/heads/master@{#424886}
==========

[commit-bot: I haz the power, 2016-10-12 22:38:00]

Patchset 1 (id:??) landed as
https://crrev.com/e3e4bdd8b41ecb5a6ed5564cafe40bebbcbe1d47
Cr-Commit-Position: refs/heads/master@{#424886}