Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: net/quic/core/quic_client_promised_info_test.cc

Issue 2412483004: relnote: Add a new RstStreamErrorCode for resetting streams due to push stream is unclaimed and tim… (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/quic_client_promised_info_test.cc
diff --git a/net/quic/core/quic_client_promised_info_test.cc b/net/quic/core/quic_client_promised_info_test.cc
index 20fdea6e8f72a06d4dd94a64a26acd382e92eae8..f8b24d8460ecd2327f85cd0134777a23e78cd382 100644
--- a/net/quic/core/quic_client_promised_info_test.cc
+++ b/net/quic/core/quic_client_promised_info_test.cc
@@ -167,8 +167,13 @@ TEST_F(QuicClientPromisedInfoTest, PushPromiseCleanupAlarm) {
ASSERT_NE(promised, nullptr);
// Fire the alarm that will cancel the promised stream.
- EXPECT_CALL(*connection_,
- SendRstStream(promise_id_, QUIC_STREAM_CANCELLED, 0));
+ if (FLAGS_quic_send_push_stream_timed_out_error) {
+ EXPECT_CALL(*connection_,
+ SendRstStream(promise_id_, QUIC_PUSH_STREAM_TIMED_OUT, 0));
+ } else {
+ EXPECT_CALL(*connection_,
+ SendRstStream(promise_id_, QUIC_STREAM_CANCELLED, 0));
+ }
alarm_factory_.FireAlarm(QuicClientPromisedInfoPeer::GetAlarm(promised));
// Verify that the promise is gone after the alarm fires.

Powered by Google App Engine
This is Rietveld 408576698