Issue 2412363002: Switch PopupHeaderView labels to use the GridLayout for automatic sizing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2412363002: Switch PopupHeaderView labels to use the GridLayout for automatic sizing. (Closed)

Created:
4 years, 2 months ago by lgarron

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Switch PopupHeaderView labels to use the GridLayout for automatic sizing. This allows https://codereview.chromium.org/2306673003 to simply call SizeToContents() on the entire WebsiteSettingsPopupView without having to manually re-layout the header. BUG=654153 Review-Url: https://codereview.chromium.org/2400883002 Cr-Commit-Position: refs/heads/master@{#424241} (cherry picked from commit 6ae90d7232f7d5fc9032e13b4d309a9282c4fd22) Committed: https://chromium.googlesource.com/chromium/src/+/0af7d0edfddd038461850cbc8957f1fba1686df9

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -9 lines)			Patch
	M	chrome/browser/ui/views/website_settings/website_settings_popup_view.cc	View		4 chunks	+2 lines, -9 lines	0 comments	Download

Total messages: 2 (1 generated)

lgarron

4 years, 2 months ago (2016-10-13 00:50:21 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0af7d0edfddd038461850cbc8957f1fba1686df9.