Switch PopupHeaderView labels to use the GridLayout for automatic sizing.

Switch PopupHeaderView labels to use the GridLayout for automatic sizing.

This allows https://codereview.chromium.org/2306673003 to simply call SizeToContents() on the entire WebsiteSettingsPopupView without having to manually re-layout the header.

BUG=654153
Committed: https://crrev.com/6ae90d7232f7d5fc9032e13b4d309a9282c4fd22
Cr-Commit-Position: refs/heads/master@{#424241}

[lgarron, 2016-10-07 00:35:20]

lgarron@chromium.org changed reviewers:
+ msw@chromium.org

[lgarron, 2016-10-07 00:35:21]

msw@, could you review?

I understand Views layout a lot better than when I cobbled the previous code
together (or inherited it, or whatever).
This change is more straightforward, and I tested that it has the right
behaviour when the bubble grows for https://codereview.chromium.org/2306673003

[msw, 2016-10-08 00:29:49]

rubber stamp lgtm; not sure exactly how this works...

[lgarron, 2016-10-08 00:51:46]

On 2016/10/08 at 00:29:49, msw wrote:
> rubber stamp lgtm; not sure exactly how this works...

Basically, the existing code did manual styled label sizing at creation time
(the SizeToFit hack).
Setting the parent columns to FILL has the same effect, but also works when the
bubble resizes.

[lgarron, 2016-10-08 00:51:47]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2016-10-08 00:52:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2016-10-08 00:53:55]

Description was changed from

==========
Switch PopupHeaderView labels to use the GridLayout for automatic sizing.

This allows https://codereview.chromium.org/2306673003 to simply call
SizeToContents() on the entire WebsiteSettingsPopupView without having to
manually re-layout the header.

BUG=
==========

to

==========
Switch PopupHeaderView labels to use the GridLayout for automatic sizing.

This allows https://codereview.chromium.org/2306673003 to simply call
SizeToContents() on the entire WebsiteSettingsPopupView without having to
manually re-layout the header.

BUG=654153
==========

[lgarron, 2016-10-08 01:00:21]

The CQ bit was unchecked by lgarron@chromium.org

[lgarron, 2016-10-08 01:00:25]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 01:00:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-10-08 01:08:01]

On 2016/10/08 00:51:46, lgarron wrote:
> On 2016/10/08 at 00:29:49, msw wrote:
> > rubber stamp lgtm; not sure exactly how this works...
> 
> Basically, the existing code did manual styled label sizing at creation time
> (the SizeToFit hack).
> Setting the parent columns to FILL has the same effect, but also works when
the
> bubble resizes.

Nice! Thanks for the explanation; your views layout detective skills are sharp!
lgtm

[commit-bot: I haz the power, 2016-10-08 01:44:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 01:44:22]

Dry run: This issue passed the CQ dry run.

[lgarron, 2016-10-10 19:36:18]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2016-10-10 19:36:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 21:14:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-10 21:17:58]

Description was changed from

==========
Switch PopupHeaderView labels to use the GridLayout for automatic sizing.

This allows https://codereview.chromium.org/2306673003 to simply call
SizeToContents() on the entire WebsiteSettingsPopupView without having to
manually re-layout the header.

BUG=654153
==========

to

==========
Switch PopupHeaderView labels to use the GridLayout for automatic sizing.

This allows https://codereview.chromium.org/2306673003 to simply call
SizeToContents() on the entire WebsiteSettingsPopupView without having to
manually re-layout the header.

BUG=654153

Committed: https://crrev.com/6ae90d7232f7d5fc9032e13b4d309a9282c4fd22
Cr-Commit-Position: refs/heads/master@{#424241}
==========

[commit-bot: I haz the power, 2016-10-10 21:17:59]

Patchset 1 (id:??) landed as
https://crrev.com/6ae90d7232f7d5fc9032e13b4d309a9282c4fd22
Cr-Commit-Position: refs/heads/master@{#424241}