Remove direct references to hermetic mac toolchain.

Remove direct references to hermetic mac toolchain.

This ensures that the hermetic toolchain is only used if use_system_xcode is
false. This CL also causes two changes:
  * svn is assumed to be installed on the system. It is not pulled from the
  hermetic toolchain.
  * mac_sdk_build was used to populate the SDK version in the Info.plist. This
  was being populated with a different version than the SDK being used to build
  Chrome, which is incorrect.

BUG=651267
Committed: https://crrev.com/6218c34684254f1c090bf501f6c46b0a69b63ec5
Cr-Commit-Position: refs/heads/master@{#425170}

[erikchen, 2016-10-13 17:57:26]

Description was changed from

==========
Remove direct references to hermetic mac toolchain.

BUG=
==========

to

==========
Remove direct references to hermetic mac toolchain.

This ensures that the hermetic toolchain is only used if use_system_xcode is
false. This CL also causes two changes:
  * svn is assumed to be installed on the system. It is not pulled from the
  hermetic toolchain.
  * mac_sdk_build was used to populate the SDK version in the Info.plist. This
  was being populated with a different version than the SDK being used to build
  Chrome, which is incorrect.

BUG=
==========

[erikchen, 2016-10-13 17:58:14]

erikchen@chromium.org changed reviewers:
+ rsesek@chromium.org

[erikchen, 2016-10-13 17:58:15]

rsesek: Please review.

[erikchen, 2016-10-13 18:01:16]

Description was changed from

==========
Remove direct references to hermetic mac toolchain.

This ensures that the hermetic toolchain is only used if use_system_xcode is
false. This CL also causes two changes:
  * svn is assumed to be installed on the system. It is not pulled from the
  hermetic toolchain.
  * mac_sdk_build was used to populate the SDK version in the Info.plist. This
  was being populated with a different version than the SDK being used to build
  Chrome, which is incorrect.

BUG=
==========

to

==========
Remove direct references to hermetic mac toolchain.

This ensures that the hermetic toolchain is only used if use_system_xcode is
false. This CL also causes two changes:
  * svn is assumed to be installed on the system. It is not pulled from the
  hermetic toolchain.
  * mac_sdk_build was used to populate the SDK version in the Info.plist. This
  was being populated with a different version than the SDK being used to build
  Chrome, which is incorrect.

BUG=651267
==========

[erikchen, 2016-10-13 18:01:59]

erikchen@chromium.org changed reviewers:
+ justincohen@chromium.org

[erikchen, 2016-10-13 18:02:00]

justincohen: Please review.

[justincohen, 2016-10-13 18:09:09]

https://codereview.chromium.org/2412353003/diff/40001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (left):

https://codereview.chromium.org/2412353003/diff/40001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:177: mac_toolchain.SetToolchainEnvironment()
Does this file not need --developer_dir anymore?

[erikchen, 2016-10-13 19:43:54]

https://codereview.chromium.org/2412353003/diff/40001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (left):

https://codereview.chromium.org/2412353003/diff/40001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:177: mac_toolchain.SetToolchainEnvironment()
On 2016/10/13 18:09:09, justincohen wrote:
> Does this file not need --developer_dir anymore?

As I indicate in the commit message:
"""
svn is assumed to be installed on the system. It is not pulled from the hermetic
toolchain.
"""

[erikchen, 2016-10-13 19:44:01]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 19:44:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2016-10-13 20:24:47]

erikchen@chromium.org changed reviewers:
+ dpranke@chromium.org

[erikchen, 2016-10-13 20:24:47]

dpranke: Please review.

[Dirk Pranke, 2016-10-13 20:33:39]

dpranke@chromium.org changed reviewers:
+ hans@chromium.org, thakis@chromium.org

[Dirk Pranke, 2016-10-13 20:33:39]

lgtm.

+thakis, hans :

I wonder if the dependency on svn is going to bite us at some point, since I
don't know that we need it for anything else these days; should we be pulling
clang from a git mirror on googlesource.com, maybe?

[justincohen, 2016-10-13 20:34:22]

lgtm

https://codereview.chromium.org/2412353003/diff/60001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/2412353003/diff/60001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:170: svn_info = subprocess.check_output('svn info
' + svn_repo, shell=True)
I wonder what changed -- this used to fail before with hermetic

[Dirk Pranke, 2016-10-13 20:40:32]

On 2016/10/13 20:33:39, Dirk Pranke wrote:
> lgtm.
> 
> +thakis, hans :
> 
> I wonder if the dependency on svn is going to bite us at some point, since I
> don't know that we need it for anything else these days; should we be pulling
> clang from a git mirror on http://googlesource.com, maybe?

Actually, I'll take this off-thread and file a bug to follow up.

[erikchen, 2016-10-13 20:42:48]

https://codereview.chromium.org/2412353003/diff/60001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/2412353003/diff/60001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:170: svn_info = subprocess.check_output('svn info
' + svn_repo, shell=True)
On 2016/10/13 20:34:22, justincohen wrote:
> I wonder what changed -- this used to fail before with hermetic

The only thing I can think of is that when this failed, it was failing on a
machine with neither CLT nor XCode. That's starting to look more and more like
an unrealistic condition for us to try to work around. We should assume that the
system already has at least a CLT install.

[erikchen, 2016-10-13 20:42:57]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-10-13 20:43:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-10-13 20:46:18]

On 2016/10/13 20:40:32, Dirk Pranke wrote:
> > +thakis, hans :
> > 
> > I wonder if the dependency on svn is going to bite us at some point, since I
> > don't know that we need it for anything else these days; should we be
pulling
> > clang from a git mirror on http://googlesource.com, maybe?
> 
> Actually, I'll take this off-thread and file a bug to follow up.

Bug: crbug.com/655790 :).

[commit-bot: I haz the power, 2016-10-13 21:35:09]

Description was changed from

==========
Remove direct references to hermetic mac toolchain.

This ensures that the hermetic toolchain is only used if use_system_xcode is
false. This CL also causes two changes:
  * svn is assumed to be installed on the system. It is not pulled from the
  hermetic toolchain.
  * mac_sdk_build was used to populate the SDK version in the Info.plist. This
  was being populated with a different version than the SDK being used to build
  Chrome, which is incorrect.

BUG=651267
==========

to

==========
Remove direct references to hermetic mac toolchain.

This ensures that the hermetic toolchain is only used if use_system_xcode is
false. This CL also causes two changes:
  * svn is assumed to be installed on the system. It is not pulled from the
  hermetic toolchain.
  * mac_sdk_build was used to populate the SDK version in the Info.plist. This
  was being populated with a different version than the SDK being used to build
  Chrome, which is incorrect.

BUG=651267
==========

[commit-bot: I haz the power, 2016-10-13 21:35:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-13 21:38:19]

Description was changed from

==========
Remove direct references to hermetic mac toolchain.

This ensures that the hermetic toolchain is only used if use_system_xcode is
false. This CL also causes two changes:
  * svn is assumed to be installed on the system. It is not pulled from the
  hermetic toolchain.
  * mac_sdk_build was used to populate the SDK version in the Info.plist. This
  was being populated with a different version than the SDK being used to build
  Chrome, which is incorrect.

BUG=651267
==========

to

==========
Remove direct references to hermetic mac toolchain.

This ensures that the hermetic toolchain is only used if use_system_xcode is
false. This CL also causes two changes:
  * svn is assumed to be installed on the system. It is not pulled from the
  hermetic toolchain.
  * mac_sdk_build was used to populate the SDK version in the Info.plist. This
  was being populated with a different version than the SDK being used to build
  Chrome, which is incorrect.

BUG=651267

Committed: https://crrev.com/6218c34684254f1c090bf501f6c46b0a69b63ec5
Cr-Commit-Position: refs/heads/master@{#425170}
==========

[commit-bot: I haz the power, 2016-10-13 21:38:20]

Patchset 4 (id:??) landed as
https://crrev.com/6218c34684254f1c090bf501f6c46b0a69b63ec5
Cr-Commit-Position: refs/heads/master@{#425170}