Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: tools/clang/scripts/update.py

Issue 2412353003: Remove direct references to hermetic mac toolchain. (Closed)
Patch Set: Remove unused import. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/mac_toolchain.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/scripts/update.py
diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py
index d3cf8e0c821485363658ed8c02ab75888dc24d95..e8601007e539957682424667e58bed7d76ebc5d8 100755
--- a/tools/clang/scripts/update.py
+++ b/tools/clang/scripts/update.py
@@ -167,14 +167,6 @@ def WriteStampFile(s, path=STAMP_FILE):
def GetSvnRevision(svn_repo):
"""Returns current revision of the svn repo at svn_repo."""
- if sys.platform == 'darwin':
- # mac_files toolchain must be set for hermetic builds.
- root = os.path.dirname(os.path.dirname(os.path.dirname(
- os.path.dirname(__file__))))
- sys.path.append(os.path.join(root, 'build'))
- import mac_toolchain
-
- mac_toolchain.SetToolchainEnvironment()
svn_info = subprocess.check_output('svn info ' + svn_repo, shell=True)
justincohen 2016/10/13 20:34:22 I wonder what changed -- this used to fail before
erikchen 2016/10/13 20:42:48 The only thing I can think of is that when this fa
m = re.search(r'Revision: (\d+)', svn_info)
return m.group(1)
« no previous file with comments | « build/mac_toolchain.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698