Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2412343004: MD Settings: roll paper-submenu to fix double-tap bug when started open (Closed)

Created:
4 years, 2 months ago by Dan Beam
Modified:
4 years, 2 months ago
Reviewers:
CC:
arv+watch_chromium.org, asanka, chromium-reviews, dbeam+watch-downloads_chromium.org, dbeam+watch-closure_chromium.org, dbeam+watch-history_chromium.org, dbeam+watch-polymer_chromium.org, Patrick Dubroy, jlklein+watch-closure_chromium.org, michaelpg+watch-polymer_chromium.org, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, vitalyp+closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: roll paper-submenu to fix double-tap bug when started open BUG=650951 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Total comments: 2

Messages

Total messages: 6 (3 generated)
dpapad
https://codereview.chromium.org/2412343004/diff/1/third_party/polymer/v1_0/bower.json File third_party/polymer/v1_0/bower.json (right): https://codereview.chromium.org/2412343004/diff/1/third_party/polymer/v1_0/bower.json#newcode52 third_party/polymer/v1_0/bower.json:52: "paper-menu": "PolymerElements/paper-menu#opened-binding", Is this better than updating our local ...
4 years, 2 months ago (2016-10-14 21:17:12 UTC) #2
Dan Beam
stop looking for extra work ;) https://codereview.chromium.org/2412343004/diff/1/third_party/polymer/v1_0/bower.json File third_party/polymer/v1_0/bower.json (right): https://codereview.chromium.org/2412343004/diff/1/third_party/polymer/v1_0/bower.json#newcode52 third_party/polymer/v1_0/bower.json:52: "paper-menu": "PolymerElements/paper-menu#opened-binding", On ...
4 years, 2 months ago (2016-10-14 21:32:56 UTC) #5
dpapad
4 years, 2 months ago (2016-10-14 21:47:55 UTC) #6
On 2016/10/14 at 21:32:56, dbeam wrote:
> stop looking for extra work ;)
> 
>
https://codereview.chromium.org/2412343004/diff/1/third_party/polymer/v1_0/bo...
> File third_party/polymer/v1_0/bower.json (right):
> 
>
https://codereview.chromium.org/2412343004/diff/1/third_party/polymer/v1_0/bo...
> third_party/polymer/v1_0/bower.json:52: "paper-menu":
"PolymerElements/paper-menu#opened-binding",
> On 2016/10/14 21:17:12, dpapad wrote:
> > Is this better than updating our local patch file?
> 
> eh, if we were actually to do this, i'd name it something generic like
"chrome-fork" or something.
> 
> this was just a WIP thing.  I didn't publish.

Ah, I am sorry, habit.

Powered by Google App Engine
This is Rietveld 408576698