Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: third_party/polymer/v1_0/components-chromium/paper-menu/paper-submenu-extracted.js

Issue 2412343004: MD Settings: roll paper-submenu to fix double-tap bug when started open (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/polymer/v1_0/components-chromium/paper-menu/paper-submenu-extracted.js
diff --git a/third_party/polymer/v1_0/components-chromium/paper-menu/paper-submenu-extracted.js b/third_party/polymer/v1_0/components-chromium/paper-menu/paper-submenu-extracted.js
index 7ca7c022b4b67e9382d996cdb0711862d0841a09..2beee1d4aad63e863a670eadc11ab5e777c032dd 100644
--- a/third_party/polymer/v1_0/components-chromium/paper-menu/paper-submenu-extracted.js
+++ b/third_party/polymer/v1_0/components-chromium/paper-menu/paper-submenu-extracted.js
@@ -54,7 +54,7 @@
this.listen(this.__parent, 'iron-activate', '_onParentIronActivate');
},
- dettached: function() {
+ detached: function() {
this.unlisten(this.__parent, 'iron-activate', '_onParentIronActivate');
},
@@ -62,9 +62,9 @@
* Expand the submenu content.
*/
open: function() {
- if (!this.disabled && !this._active) {
+ if (!this.disabled && !this.opened) {
this.$.collapse.show();
- this._active = true;
+ this.opened = true;
this.__trigger && this.__trigger.classList.add('iron-selected');
this.__content && this.__content.focus();
}
@@ -74,9 +74,9 @@
* Collapse the submenu content.
*/
close: function() {
- if (this._active) {
+ if (this.opened) {
this.$.collapse.hide();
- this._active = false;
+ this.opened = false;
this.__trigger && this.__trigger.classList.remove('iron-selected');
}
},
@@ -85,7 +85,7 @@
* Toggle the submenu.
*/
toggle: function() {
- if (this._active) {
+ if (this.opened) {
this.close();
} else {
this.open();
@@ -137,7 +137,7 @@
*/
_disabledChanged: function(disabled) {
Polymer.IronControlState._disabledChanged.apply(this, arguments);
- if (disabled && this._active) {
+ if (disabled && this.opened) {
this.close();
}
},

Powered by Google App Engine
This is Rietveld 408576698