Issue 24123006: Remove SendFakeProcessKeyEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24123006: Remove SendFakeProcessKeyEvent. (Closed)

Created:
7 years, 3 months ago by Seigo Nonaka

Modified:
6 years, 7 months ago

Reviewers:
Shu Chen, Zachary Kuznia

CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org, Hiro Komatsu

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove SendFakeProcessKeyEvent. There is a weired hack in UpdatePreedit or CommitText which sends VKEY_PROCESS(229) into to text input client if the event is not based on keyboard event. However sending VKEY_PROCESS key event means that some key is consumed by input method. So that it is not appropriate to generate. BUG=289105 TEST=Manually done Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223767

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -14 lines)			Patch
	M	ui/base/ime/input_method_ibus.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	ui/base/ime/input_method_ibus.cc	View		3 chunks	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Seigo Nonaka

Hi Zach, could you take a look at this CL? Thank you.

7 years, 3 months ago (2013-09-17 11:19:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/24123006/1

7 years, 3 months ago (2013-09-17 22:14:44 UTC) #3

Shu Chen

6 years, 7 months ago (2014-05-22 06:50:41 UTC) #5

Message was sent while issue was closed.

I'm going to revert this cl because it breaks on-screen keyboard IMEs.

Expand Messages | Collapse Messages