Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2412203002: MD Settings: Restore site_details.html import. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
4 years, 2 months ago
Reviewers:
dschuyler, Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Restore site_details.html import. BUG=655039 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7a71f3f0e8120ead88cfadf6bbef8b5bb5383746 Cr-Commit-Position: refs/heads/master@{#424821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/settings/site_settings/site_settings_category.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dpapad
I had removed a bunch of dependencies at https://codereview.chromium.org/2400043004 which caused the problem. It is ...
4 years, 2 months ago (2016-10-12 18:05:34 UTC) #3
Dan Beam
lgtm
4 years, 2 months ago (2016-10-12 18:11:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412203002/1
4 years, 2 months ago (2016-10-12 18:15:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 19:28:11 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 19:32:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a71f3f0e8120ead88cfadf6bbef8b5bb5383746
Cr-Commit-Position: refs/heads/master@{#424821}

Powered by Google App Engine
This is Rietveld 408576698