MD Settings: Cleanup, remove obsolete dependencies.

MD Settings: Cleanup, remove obsolete dependencies.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a9476ed3aa13a0bba14d20af44724b8f824bc5a0
Cr-Commit-Position: refs/heads/master@{#424332}

[dpapad, 2016-10-07 23:53:03]

Description was changed from

==========
MD Settings: Cleanup, remove obsolete dependencies.

BUG=
==========

to

==========
MD Settings: Cleanup, remove obsolete dependencies.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-10-07 23:53:08]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 23:53:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-10-08 01:23:24]

Description was changed from

==========
MD Settings: Cleanup, remove obsolete dependencies.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Cleanup, remove obsolete dependencies.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-10-08 01:23:49]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 01:24:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-10-08 01:28:34]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[commit-bot: I haz the power, 2016-10-08 03:35:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 03:35:20]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-10-08 08:40:42]

lgtm w/ a bunch of optional follow-up :-)

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(left):

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:12:
<link rel="import" href="/icons.html">
remove?

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.html (left):

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.html:3: <link
rel="import"
href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
i think we can remove paper-button from the display_layout target in
compiled_resources2.gyp (also the display target): the PaperButtonElement in
display_layout.js should be HTMLDivElement.

Feel free to also add a TODO in display_layout.js asking stevenjb wtf the
"active" property on a div is...

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.html
(left):

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.html:2:
<link rel="import" href="chrome://resources/cr_elements/icons.html">
remove

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_summary_item.html
(left):

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_summary_item.html:8:
<link rel="import"
href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
add paper-icon-button

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_page.html
(left):

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.html:13: <link
rel="import" href="/icons.html">
remove

[dpapad, 2016-10-10 17:52:47]

@michaelpg: See question in display_layout.js

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(left):

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:12:
<link rel="import" href="/icons.html">
On 2016/10/08 at 08:40:41, michaelpg (OOO M-W) wrote:
> remove?

Done.

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.html (left):

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.html:3: <link
rel="import"
href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
On 2016/10/08 at 08:40:41, michaelpg (OOO M-W) wrote:
> i think we can remove paper-button from the display_layout target in
compiled_resources2.gyp (also the display target): the PaperButtonElement in
display_layout.js should be HTMLDivElement.
> 
> Feel free to also add a TODO in display_layout.js asking stevenjb wtf the
"active" property on a div is...

Done.

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.html
(left):

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.html:2:
<link rel="import" href="chrome://resources/cr_elements/icons.html">
On 2016/10/08 at 08:40:41, michaelpg (OOO M-W) wrote:
> remove

Done.

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_summary_item.html
(left):

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_summary_item.html:8:
<link rel="import"
href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
On 2016/10/08 at 08:40:42, michaelpg (OOO M-W) wrote:
> add paper-icon-button

Done.

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_page.html
(left):

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.html:13: <link
rel="import" href="/icons.html">
On 2016/10/08 at 08:40:42, michaelpg (OOO M-W) wrote:
> remove

I think this one is being used, see line 119 cr:more-vert and line 157
cr:settings.

https://codereview.chromium.org/2400043004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.js (right):

https://codereview.chromium.org/2400043004/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:196: onDrag_:
function(id, amount) {
How was this working before?

[dpapad, 2016-10-10 22:34:24]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-10-10 22:34:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2400043004/#ps40001
(title: "Addressing comments.")

[commit-bot: I haz the power, 2016-10-10 22:34:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2016-10-10 23:49:41]

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_page.html
(left):

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.html:13: <link
rel="import" href="/icons.html">
On 2016/10/10 17:52:47, dpapad wrote:
> On 2016/10/08 at 08:40:42, michaelpg (OOO M-W) wrote:
> > remove
> 
> I think this one is being used, see line 119 cr:more-vert and line 157
> cr:settings.

so that's cr_elements/icons.html (above); /icons.html is Settings' icons file.

https://codereview.chromium.org/2400043004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.js (right):

https://codereview.chromium.org/2400043004/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:196: onDrag_:
function(id, amount) {
On 2016/10/10 17:52:47, dpapad wrote:
> How was this working before?

Valid ES6

[dpapad, 2016-10-10 23:59:27]

The CQ bit was unchecked by dpapad@chromium.org

[dpapad, 2016-10-11 00:17:50]

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_page.html
(left):

https://codereview.chromium.org/2400043004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.html:13: <link
rel="import" href="/icons.html">
> so that's cr_elements/icons.html (above); /icons.html is Settings' icons file.

Ah ok. Removed.

https://codereview.chromium.org/2400043004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.js (right):

https://codereview.chromium.org/2400043004/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:196: onDrag_:
function(id, amount) {
On 2016/10/10 at 23:49:41, michaelpg (OOO M-W) wrote:
> On 2016/10/10 17:52:47, dpapad wrote:
> > How was this working before?
> 
> Valid ES6

Did not know that ES6 class syntax can be used without actually using the
"class" keyword, fun.

[dpapad, 2016-10-11 00:18:01]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-10-11 00:18:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2400043004/#ps60001
(title: "Remove more.")

[commit-bot: I haz the power, 2016-10-11 00:18:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 00:18:21]

This CL has an open dependency (Issue 2409813002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[dpapad, 2016-10-11 00:32:33]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-10-11 00:32:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2400043004/#ps80001
(title: "No diff")

[commit-bot: I haz the power, 2016-10-11 00:33:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 01:33:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-11 01:35:25]

Description was changed from

==========
MD Settings: Cleanup, remove obsolete dependencies.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Cleanup, remove obsolete dependencies.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a9476ed3aa13a0bba14d20af44724b8f824bc5a0
Cr-Commit-Position: refs/heads/master@{#424332}
==========

[commit-bot: I haz the power, 2016-10-11 01:35:26]

Patchset 5 (id:??) landed as
https://crrev.com/a9476ed3aa13a0bba14d20af44724b8f824bc5a0
Cr-Commit-Position: refs/heads/master@{#424332}