Source/core/frame/Screen.idl - Issue 241203003: Screen Orientation: fire event on Window instead of Screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/Screen.idl

Issue 241203003: Screen Orientation: fire event on Window instead of Screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@ScreenOrientationUndefined

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/frame/Screen.cpp ('k') | Source/modules/screen_orientation/ScreenOrientation.idl » ('j') | Source/modules/screen_orientation/ScreenOrientationController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/Screen.idl

diff --git a/Source/core/frame/Screen.idl b/Source/core/frame/Screen.idl

index 156795fe32390d2e13ea638ed9aaab0c725a1c52..a0b6385676f5983aa7c75aefb6bcf4c170b931ed 100644

--- a/Source/core/frame/Screen.idl

+++ b/Source/core/frame/Screen.idl

@@ -29,7 +29,7 @@

[

WillBeGarbageCollected,

-] interface Screen : EventTarget {

Inactive 2014/04/17 20:31:42 Technically, this change will need approval from a

mlamouri (slow - plz ping) 2014/04/17 20:36:07 I doubt this will be a problem but let's add Adam

abarth-chromium 2014/04/17 23:36:47 It seems like a pretty minor change. It's possibl

+] interface Screen {

readonly attribute unsigned long height;

readonly attribute unsigned long width;

readonly attribute unsigned long colorDepth;