Source/core/frame/Screen.idl - Issue 241203003: Screen Orientation: fire event on Window instead of Screen.

Side by Side Diff: Source/core/frame/Screen.idl

Issue 241203003: Screen Orientation: fire event on Window instead of Screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@ScreenOrientationUndefined

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/frame/Screen.cpp ('k') | Source/modules/screen_orientation/ScreenOrientation.idl » ('j') | Source/modules/screen_orientation/ScreenOrientationController.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007 Apple Inc. All rights reserved.	2 * Copyright (C) 2007 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 11 matching lines...) Expand all Loading...
22 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;	22 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;

23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND	23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND

24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT	24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF	25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF

26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

27 */	27 */

28	28

29	29

30 [	30 [

31 WillBeGarbageCollected,	31 WillBeGarbageCollected,

32 ] interface Screen : EventTarget {	32 ] interface Screen {
Inactive 2014/04/17 20:31:42 Technically, this change will need approval from a Technically, this change will need approval from an API owner as it is web exposed and not behind a runtime flag. This was added recently though, did this ship yet (i.e. is it in M34?). mlamouri (slow - plz ping) 2014/04/17 20:36:07 I doubt this will be a problem but let's add Adam Show quoted text On 2014/04/17 20:31:42, Chris Dumez wrote: > Technically, this change will need approval from an API owner as it is web > exposed and not behind a runtime flag. This was added recently though, did this > ship yet (i.e. is it in M34?). I doubt this will be a problem but let's add Adam in the reviewers list. abarth-chromium 2014/04/17 23:36:47 It seems like a pretty minor change. It's possibl Show quoted text On 2014/04/17 20:36:07, Mounir Lamouri wrote: > I doubt this will be a problem but let's add Adam in the reviewers list. It seems like a pretty minor change. It's possible we'll break something, but I'm not sure worried about it.
33 readonly attribute unsigned long height;	33 readonly attribute unsigned long height;

34 readonly attribute unsigned long width;	34 readonly attribute unsigned long width;

35 readonly attribute unsigned long colorDepth;	35 readonly attribute unsigned long colorDepth;

36 readonly attribute unsigned long pixelDepth;	36 readonly attribute unsigned long pixelDepth;

37 readonly attribute long availLeft;	37 readonly attribute long availLeft;

38 readonly attribute long availTop;	38 readonly attribute long availTop;

39 readonly attribute unsigned long availHeight;	39 readonly attribute unsigned long availHeight;

40 readonly attribute unsigned long availWidth;	40 readonly attribute unsigned long availWidth;

41 };	41 };

42	42

OLD	NEW