Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2412023002: DevTools: migrate InspectorView to tabbed view location. (Closed)
Patch Set: test fixed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
index aff3f1680709c7144d4c71fd072c41a4888a4eb2..a86df7e6ae3a05fbb75c4c02a53aecd93f8dc237 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
@@ -502,8 +502,7 @@ WebInspector.NetworkPanel.prototype = {
*/
function reveal(request)
{
- WebInspector.inspectorView.setCurrentPanel(this);
- this.revealAndHighlightRequest(request);
+ WebInspector.viewManager.showView("network").then(this.revealAndHighlightRequest.bind(this, request));
}
/**
@@ -624,18 +623,10 @@ WebInspector.NetworkPanel.RequestRevealer.prototype = {
if (!(request instanceof WebInspector.NetworkRequest))
return Promise.reject(new Error("Internal error: not a network request"));
var panel = WebInspector.NetworkPanel._instance();
- WebInspector.inspectorView.setCurrentPanel(panel);
- panel.revealAndHighlightRequest(request);
- return Promise.resolve();
+ return WebInspector.viewManager.showView("network").then(panel.revealAndHighlightRequest.bind(panel, request));
}
}
-
-WebInspector.NetworkPanel.show = function()
-{
- WebInspector.inspectorView.setCurrentPanel(WebInspector.NetworkPanel._instance());
-}
-
/**
* @param {!Array<{filterType: !WebInspector.NetworkLogView.FilterType, filterValue: string}>} filters
*/
@@ -646,7 +637,7 @@ WebInspector.NetworkPanel.revealAndFilter = function(filters)
for (var filter of filters)
filterString += `${filter.filterType}:${filter.filterValue} `;
panel._networkLogView.setTextFilterValue(filterString);
- WebInspector.inspectorView.setCurrentPanel(panel);
+ WebInspector.viewManager.showView("network");
}
/**

Powered by Google App Engine
This is Rietveld 408576698