Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js

Issue 2412023002: DevTools: migrate InspectorView to tabbed view location. (Closed)
Patch Set: test fixed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js b/third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js
index 38a08ae989b049ff8e4c56af042ac4dfc87e725a..8cfa3c07a8b749ceee31497c81d8a2a355d4e4ef 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js
@@ -89,7 +89,7 @@ WebInspector.ConsolePanel.WrapperView = function()
WebInspector.ConsolePanel.WrapperView.prototype = {
wasShown: function()
{
- if (!WebInspector.inspectorView.currentPanel() || WebInspector.inspectorView.currentPanel().name !== "console")
+ if (!WebInspector.ConsolePanel.instance().isShowing())
this._showViewInWrapper();
else
WebInspector.inspectorView.setDrawerMinimized(true);
@@ -129,20 +129,23 @@ WebInspector.ConsolePanel.ConsoleRevealer.prototype = {
consoleView.focus();
return Promise.resolve();
}
- WebInspector.viewManager.showView("console");
+ WebInspector.viewManager.showView("console-view");
return Promise.resolve();
}
}
+/**
+ * @return {!Promise}
+ */
WebInspector.ConsolePanel.show = function()
dgozman 2016/10/12 04:47:40 Let's maybe remove this one? I didn't find non-tes
pfeldman 2016/10/12 19:02:33 Done.
{
- WebInspector.inspectorView.setCurrentPanel(WebInspector.ConsolePanel._instance());
+ return WebInspector.viewManager.showView("console");
}
/**
* @return {!WebInspector.ConsolePanel}
*/
-WebInspector.ConsolePanel._instance = function()
+WebInspector.ConsolePanel.instance = function()
{
return /** @type {!WebInspector.ConsolePanel} */ (self.runtime.sharedInstance(WebInspector.ConsolePanel));
}

Powered by Google App Engine
This is Rietveld 408576698