third_party/WebKit/Source/devtools/front_end/main/Main.js - Issue 2412023002: DevTools: migrate InspectorView to tabbed view location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/Main.js

Issue 2412023002: DevTools: migrate InspectorView to tabbed view location. (Closed)

Patch Set: test fixed Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js ('K') | « third_party/WebKit/Source/devtools/front_end/layers/module.json ('k') | third_party/WebKit/Source/devtools/front_end/main/SimpleApp.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/main/Main.js

diff --git a/third_party/WebKit/Source/devtools/front_end/main/Main.js b/third_party/WebKit/Source/devtools/front_end/main/Main.js

index 5b97e35cb3a97cf1a28b426b3a8c7dfa1fc6d2c3..1f319025111ef0792dcd9d9cdde786513729dd88 100644

--- a/third_party/WebKit/Source/devtools/front_end/main/Main.js

+++ b/third_party/WebKit/Source/devtools/front_end/main/Main.js

@@ -479,8 +479,8 @@ WebInspector.Main.prototype = {

event.preventDefault();

}

- if (!WebInspector.Dialog.hasInstance() && WebInspector.inspectorView.currentPanel()) {

- WebInspector.inspectorView.currentPanel().handleShortcut(event);

+ if (!WebInspector.Dialog.hasInstance() && WebInspector.inspectorView.currentPanelDeprecated()) {

+ WebInspector.inspectorView.currentPanelDeprecated().handleShortcut(event);

if (event.handled) {

event.consume(true);

return;

@@ -669,7 +669,7 @@ WebInspector.Main.SearchActionDelegate.prototype = {

handleAction: function(context, actionId)

{

- var searchableView = WebInspector.SearchableView.fromElement(WebInspector.currentFocusElement()) || WebInspector.inspectorView.currentPanel().searchableView();

+ var searchableView = WebInspector.SearchableView.fromElement(WebInspector.currentFocusElement()) || WebInspector.inspectorView.currentPanelDeprecated().searchableView();

if (!searchableView)

return false;

switch (actionId) {