[Devtools] Added hover support for network timeline experiment

[Devtools] Added hover support for network timeline experiment

This patch adds hover support to the new canvas timeline.

http://imgur.com/a/3vSzd

R=lushnikov,dgozman
BUG=653738
Committed: https://crrev.com/47f5159eb03a558674e993f22b9aa0888d5ac20e
Cr-Commit-Position: refs/heads/master@{#425238}

[allada, 2016-10-12 00:09:16]

PTL

[dgozman, 2016-10-12 17:31:33]

I don't like that log view, timeline and datagrid all call each other. Can we
fix this somehow?

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:363:
_dataGridMouseMove: function(event)
Where do you disable default data grid highlight?

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:365: var
node = this._dataGrid.dataGridNodeFromNode(event.target);
Just call this._setHoveredNode(node)

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:375:
_dataGridMouseLeave: function(event)
JSDocs

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:87:
_onMouseHover: function(event)
JSDoc....

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:313:
var color = WebInspector.themeSupport.patchColor("#f5f5f5",
WebInspector.ThemeSupport.ColorUsage.Background);
We should save these colors to variables to only patch once.

[allada, 2016-10-12 19:15:17]

Patchset #3 (id:30001) has been deleted

[allada, 2016-10-12 19:15:30]

PTaL

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:363:
_dataGridMouseMove: function(event)
On 2016/10/12 17:31:32, dgozman wrote:
> Where do you disable default data grid highlight?

There isnt a default highlight... Network panel did it inside NetworkLogView
using CSS.

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:365: var
node = this._dataGrid.dataGridNodeFromNode(event.target);
On 2016/10/12 17:31:32, dgozman wrote:
> Just call this._setHoveredNode(node)

Done.

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:375:
_dataGridMouseLeave: function(event)
On 2016/10/12 17:31:32, dgozman wrote:
> JSDocs

Done.

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:87:
_onMouseHover: function(event)
On 2016/10/12 17:31:32, dgozman wrote:
> JSDoc....

Done.

https://codereview.chromium.org/2412013002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:313:
var color = WebInspector.themeSupport.patchColor("#f5f5f5",
WebInspector.ThemeSupport.ColorUsage.Background);
On 2016/10/12 17:31:32, dgozman wrote:
> We should save these colors to variables to only patch once.

Done.

[dgozman, 2016-10-12 21:05:38]

lgtm

https://codereview.chromium.org/2412013002/diff/50001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2412013002/diff/50001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:384: if
(this._hoveredNode) {
this._setHoveredNode(null);

https://codereview.chromium.org/2412013002/diff/50001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2412013002/diff/50001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:34:
this._canvas.addEventListener("mouseleave", this.setHoveredRequest.bind(this,
null), true);
Don't you have to fire an event here?

[allada, 2016-10-12 21:12:43]

https://codereview.chromium.org/2412013002/diff/50001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2412013002/diff/50001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:384: if
(this._hoveredNode) {
On 2016/10/12 21:05:38, dgozman wrote:
> this._setHoveredNode(null);

Done.

https://codereview.chromium.org/2412013002/diff/50001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2412013002/diff/50001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:34:
this._canvas.addEventListener("mouseleave", this.setHoveredRequest.bind(this,
null), true);
On 2016/10/12 21:05:38, dgozman wrote:
> Don't you have to fire an event here?

If the mouse moved from 0px to another element, we'd never get the mouse move
event to say it moved out of the element so no more events come... This is the
safest way to do it.

[allada, 2016-10-14 00:53:12]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 00:53:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 02:09:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 02:09:31]

Dry run: This issue passed the CQ dry run.

[allada, 2016-10-14 02:12:18]

The CQ bit was checked by allada@chromium.org

[allada, 2016-10-14 02:12:19]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2412013002/#ps70001
(title: "Changes")

[commit-bot: I haz the power, 2016-10-14 02:12:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 02:18:32]

Committed patchset #4 (id:70001)

[commit-bot: I haz the power, 2016-10-14 02:20:34]

Description was changed from

==========
[Devtools] Added hover support for network timeline experiment

This patch adds hover support to the new canvas timeline.

http://imgur.com/a/3vSzd

R=lushnikov,dgozman
BUG=653738
==========

to

==========
[Devtools] Added hover support for network timeline experiment

This patch adds hover support to the new canvas timeline.

http://imgur.com/a/3vSzd

R=lushnikov,dgozman
BUG=653738

Committed: https://crrev.com/47f5159eb03a558674e993f22b9aa0888d5ac20e
Cr-Commit-Position: refs/heads/master@{#425238}
==========

[commit-bot: I haz the power, 2016-10-14 02:20:35]

Patchset 4 (id:??) landed as
https://crrev.com/47f5159eb03a558674e993f22b9aa0888d5ac20e
Cr-Commit-Position: refs/heads/master@{#425238}