Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: chrome/browser/resources/md_history/side_bar.html

Issue 2412003002: MD History: Fix overlapping of sidebar footer in very short windows (Closed)
Patch Set: lshang@ review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_history/app.vulcanized.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/side_bar.html
diff --git a/chrome/browser/resources/md_history/side_bar.html b/chrome/browser/resources/md_history/side_bar.html
index 7dbcc88b3998d10caf2df97a44f34a8e64bad489..0d0fd5a4c3ea8cb82338106382966ce0c331751b 100644
--- a/chrome/browser/resources/md_history/side_bar.html
+++ b/chrome/browser/resources/md_history/side_bar.html
@@ -11,14 +11,20 @@
<template>
<style include="shared-style">
:host {
- display: block;
+ display: flex;
height: 100%;
- padding-top: 5px;
+ overflow-x: hidden;
+ overflow-y: auto;
width: var(--side-bar-width);
}
+ :host([drawer]) {
+ height: calc(100% - var(--toolbar-height));
+ }
+
div.separator {
background-color: rgba(0, 0, 0, 0.08);
+ flex-shrink: 0;
height: 1px;
margin: 8px 0;
}
@@ -40,6 +46,10 @@
-webkit-user-select: none;
background-color: transparent;
color: #5a5a5a;
+ display: flex;
+ flex: 1;
+ flex-direction: column;
+ padding-top: 8px;
}
iron-selector > a {
@@ -59,22 +69,17 @@
iron-selector > a.iron-selected {
color: var(--google-blue-500);
- font-weight: 500;
+ }
+
+ #spacer {
+ flex: 1;
}
#footer {
- bottom: 0;
color: var(--paper-grey-600);
- position: absolute;
width: var(--side-bar-width);
}
- :host([drawer]) #footer {
- /* This compensates the 120px by which app-drawer protrudes under
- * the viewport. */
- bottom: 120px;
- }
-
#footer-text {
-webkit-padding-end: 16px;
-webkit-padding-start: 24px;
@@ -108,6 +113,7 @@
<iron-icon icon="cr:open-in-new"></iron-icon>
<paper-ripple id="cbd-ripple"></paper-ripple>
</a>
+ <div id="spacer"></div>
<div id="footer" hidden="[[!showFooter]]">
<div class="separator"></div>
<div id="footer-text">$i18nRaw{sidebarFooter}</div>
« no previous file with comments | « chrome/browser/resources/md_history/app.vulcanized.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698