Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Side by Side Diff: chrome/browser/resources/md_history/side_bar.html

Issue 2412003002: MD History: Fix overlapping of sidebar footer in very short windows (Closed)
Patch Set: lshang@ review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/md_history/app.vulcanized.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys-behavior /iron-a11y-keys-behavior.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys-behavior /iron-a11y-keys-behavior.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-selector/iron-sele ctor.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-selector/iron-sele ctor.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripp le.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripp le.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html "> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html ">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/typography .html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/typography .html">
7 <link rel="import" href="chrome://history/browser_service.html"> 7 <link rel="import" href="chrome://history/browser_service.html">
8 <link rel="import" href="chrome://history/shared_style.html"> 8 <link rel="import" href="chrome://history/shared_style.html">
9 9
10 <dom-module id="history-side-bar"> 10 <dom-module id="history-side-bar">
11 <template> 11 <template>
12 <style include="shared-style"> 12 <style include="shared-style">
13 :host { 13 :host {
14 display: block; 14 display: flex;
15 height: 100%; 15 height: 100%;
16 padding-top: 5px; 16 overflow-x: hidden;
17 overflow-y: auto;
17 width: var(--side-bar-width); 18 width: var(--side-bar-width);
18 } 19 }
19 20
21 :host([drawer]) {
22 height: calc(100% - var(--toolbar-height));
23 }
24
20 div.separator { 25 div.separator {
21 background-color: rgba(0, 0, 0, 0.08); 26 background-color: rgba(0, 0, 0, 0.08);
27 flex-shrink: 0;
22 height: 1px; 28 height: 1px;
23 margin: 8px 0; 29 margin: 8px 0;
24 } 30 }
25 31
26 #clear-browsing-data { 32 #clear-browsing-data {
27 justify-content: space-between; 33 justify-content: space-between;
28 } 34 }
29 35
30 #clear-browsing-data iron-icon { 36 #clear-browsing-data iron-icon {
31 -webkit-margin-end: 24px; 37 -webkit-margin-end: 24px;
32 color: var(--paper-grey-400); 38 color: var(--paper-grey-400);
33 height: 20px; 39 height: 20px;
34 margin-bottom: 10px; 40 margin-bottom: 10px;
35 margin-top: 10px; 41 margin-top: 10px;
36 width: 20px; 42 width: 20px;
37 } 43 }
38 44
39 iron-selector { 45 iron-selector {
40 -webkit-user-select: none; 46 -webkit-user-select: none;
41 background-color: transparent; 47 background-color: transparent;
42 color: #5a5a5a; 48 color: #5a5a5a;
49 display: flex;
50 flex: 1;
51 flex-direction: column;
52 padding-top: 8px;
43 } 53 }
44 54
45 iron-selector > a { 55 iron-selector > a {
46 @apply(--paper-font-subhead); 56 @apply(--paper-font-subhead);
47 -webkit-padding-start: 24px; 57 -webkit-padding-start: 24px;
48 align-items: center; 58 align-items: center;
49 box-sizing: border-box; 59 box-sizing: border-box;
50 color: inherit; 60 color: inherit;
51 cursor: pointer; 61 cursor: pointer;
52 display: flex; 62 display: flex;
53 font-size: 14px; 63 font-size: 14px;
54 font-weight: 500; 64 font-weight: 500;
55 min-height: 48px; 65 min-height: 48px;
56 position: relative; 66 position: relative;
57 text-decoration: none; 67 text-decoration: none;
58 } 68 }
59 69
60 iron-selector > a.iron-selected { 70 iron-selector > a.iron-selected {
61 color: var(--google-blue-500); 71 color: var(--google-blue-500);
62 font-weight: 500; 72 }
73
74 #spacer {
75 flex: 1;
63 } 76 }
64 77
65 #footer { 78 #footer {
66 bottom: 0;
67 color: var(--paper-grey-600); 79 color: var(--paper-grey-600);
68 position: absolute;
69 width: var(--side-bar-width); 80 width: var(--side-bar-width);
70 } 81 }
71 82
72 :host([drawer]) #footer {
73 /* This compensates the 120px by which app-drawer protrudes under
74 * the viewport. */
75 bottom: 120px;
76 }
77
78 #footer-text { 83 #footer-text {
79 -webkit-padding-end: 16px; 84 -webkit-padding-end: 16px;
80 -webkit-padding-start: 24px; 85 -webkit-padding-start: 24px;
81 line-height: 20px; 86 line-height: 20px;
82 margin: 24px 0; 87 margin: 24px 0;
83 } 88 }
84 89
85 #footer a { 90 #footer a {
86 color: var(--google-blue-700); 91 color: var(--google-blue-700);
87 text-decoration: none; 92 text-decoration: none;
(...skipping 13 matching lines...) Expand all
101 $i18n{openTabsMenuItem} 106 $i18n{openTabsMenuItem}
102 <paper-ripple></paper-ripple> 107 <paper-ripple></paper-ripple>
103 </a> 108 </a>
104 <div class="separator"></div> 109 <div class="separator"></div>
105 <a href="chrome://settings/clearBrowserData" 110 <a href="chrome://settings/clearBrowserData"
106 on-tap="onClearBrowsingDataTap_" id="clear-browsing-data"> 111 on-tap="onClearBrowsingDataTap_" id="clear-browsing-data">
107 $i18n{clearBrowsingData} 112 $i18n{clearBrowsingData}
108 <iron-icon icon="cr:open-in-new"></iron-icon> 113 <iron-icon icon="cr:open-in-new"></iron-icon>
109 <paper-ripple id="cbd-ripple"></paper-ripple> 114 <paper-ripple id="cbd-ripple"></paper-ripple>
110 </a> 115 </a>
116 <div id="spacer"></div>
111 <div id="footer" hidden="[[!showFooter]]"> 117 <div id="footer" hidden="[[!showFooter]]">
112 <div class="separator"></div> 118 <div class="separator"></div>
113 <div id="footer-text">$i18nRaw{sidebarFooter}</div> 119 <div id="footer-text">$i18nRaw{sidebarFooter}</div>
114 </div> 120 </div>
115 </iron-selector> 121 </iron-selector>
116 </template> 122 </template>
117 <script src="chrome://history/side_bar.js"></script> 123 <script src="chrome://history/side_bar.js"></script>
118 </dom-module> 124 </dom-module>
OLDNEW
« no previous file with comments | « chrome/browser/resources/md_history/app.vulcanized.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698