Password autofill: Check for user gesture switches to new Blink backend

components/autofill/content/renderer/autofill_agent.h

Index: components/autofill/content/renderer/autofill_agent.h
diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h
index 5b268d9fdfea42dc6f3de494de468db26723586d..8be87a0b932ff4514c9968eac2024ae80d3f9444 100644
--- a/components/autofill/content/renderer/autofill_agent.h
+++ b/components/autofill/content/renderer/autofill_agent.h
@@ -90,6 +90,7 @@ class AutofillAgent : public content::RenderViewObserver,
   virtual void didAssociateFormControls(
       const blink::WebVector<blink::WebNode>& nodes);
   virtual void openTextDataListChooser(const blink::WebInputElement& element);
+  virtual void firstUserGestureObserved() OVERRIDE;

[vabr (Chromium), 2014/04/17 17:43:30]

It looks like all methods in this block should have OVERRIDE.
Should I add that to the other methods, or is it not appropriate for the new one
either?

[Ilya Sherman, 2014/04/17 21:28:47]

Actually, per request from jamesr@, none of them should have OVERRIDE, so as to
reduce the number of N-sided changes necessary when making changes that cross
the repository boundary.  We'll be able to restore the OVERRIDE annotations once
the Chromium and Blink repositories are merged (woohoo!).

[vabr (Chromium), 2014/04/18 18:23:53]

Makes sense, thanks!
OVERRIDE removed.

 
   void OnFieldTypePredictionsAvailable(
       const std::vector<FormDataPredictions>& forms);