Password autofill: Check for user gesture switches to new Blink backend

components/autofill/content/renderer/autofill_agent.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 72 matching lines @@
   virtual void textFieldDidReceiveKeyDown(
       const blink::WebInputElement& element,
       const blink::WebKeyboardEvent& event);
   virtual void didRequestAutocomplete(
       const blink::WebFormElement& form,
       const blink::WebAutocompleteParams& details);
   virtual void setIgnoreTextChanges(bool ignore);
   virtual void didAssociateFormControls(
       const blink::WebVector<blink::WebNode>& nodes);
   virtual void openTextDataListChooser(const blink::WebInputElement& element);
+  virtual void firstUserGestureObserved() OVERRIDE;

[vabr (Chromium), 2014/04/17 17:43:30]

It looks like all methods in this block should have OVERRIDE.
Should I add that to the other methods, or is it not appropriate for the new one
either?

[Ilya Sherman, 2014/04/17 21:28:47]

Actually, per request from jamesr@, none of them should have OVERRIDE, so as to
reduce the number of N-sided changes necessary when making changes that cross
the repository boundary.  We'll be able to restore the OVERRIDE annotations once
the Chromium and Blink repositories are merged (woohoo!).

[vabr (Chromium), 2014/04/18 18:23:53]

Makes sense, thanks!
OVERRIDE removed.

 
   void OnFieldTypePredictionsAvailable(
       const std::vector<FormDataPredictions>& forms);
   void OnFillForm(int query_id, const FormData& form);
   void OnPreviewForm(int query_id, const FormData& form);
 
   // For external Autofill selection.
   void OnClearForm();
   void OnClearPreviewedForm();
   void OnFillFieldWithValue(const base::string16& value);
@@ skipping 135 matching lines @@
                            NoCancelOnSubframeNavigateAfterDone);
   FRIEND_TEST_ALL_PREFIXES(RequestAutocompleteRendererTest,
                            InvokingTwiceOnlyShowsOnce);
 
   DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_