Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: ash/mus/property_util.h

Issue 2411913003: Converts ash/wm/mru_window_tracker_unittest.cc to use AshTest (Closed)
Patch Set: comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/mus/property_util.h
diff --git a/ash/mus/property_util.h b/ash/mus/property_util.h
index a0ede0188ae480c7d118266e94c1f36897b9dd73..1e9a0a89f035c5b483457ea200e4b4014ffaa395 100644
--- a/ash/mus/property_util.h
+++ b/ash/mus/property_util.h
@@ -88,6 +88,12 @@ bool ShouldRenderParentTitleArea(ui::Window* window);
// kInvalidDisplayID.
int64_t GetInitialDisplayId(const ui::Window::SharedProperties& properties);
+// Manipulates the kExcludeFromMru_Property property.
msw 2016/10/11 22:36:05 optional nit: combine comments, remove blank line
sky 2016/10/11 22:57:05 I like keeping separate as that way the comments a
+void SetExcludeFromMru(ui::Window* window, bool value);
msw 2016/10/11 22:36:05 aside: it'd be nice if these were in a window_prop
sky 2016/10/11 22:57:05 How come? Generally we don't use namespaces based
+
+// Returns true if the property is set and true, otherwise false.
+bool GetExcludeFromMru(const ui::Window* window);
msw 2016/10/11 22:36:05 very optional nit: IsExcludedFromMru? (like Is* bo
sky 2016/10/11 22:57:05 I went with this to match the name of the property
+
} // namespace mus
} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698