Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: ash/mus/property_util.h

Issue 2411913003: Converts ash/wm/mru_window_tracker_unittest.cc to use AshTest (Closed)
Patch Set: comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_MUS_PROPERTY_UTIL_H_ 5 #ifndef ASH_MUS_PROPERTY_UTIL_H_
6 #define ASH_MUS_PROPERTY_UTIL_H_ 6 #define ASH_MUS_PROPERTY_UTIL_H_
7 7
8 #include "ash/public/interfaces/ash_window_type.mojom.h" 8 #include "ash/public/interfaces/ash_window_type.mojom.h"
9 #include "ash/public/interfaces/container.mojom.h" 9 #include "ash/public/interfaces/container.mojom.h"
10 #include "services/ui/public/cpp/window.h" 10 #include "services/ui/public/cpp/window.h"
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 81
82 bool ShouldRemoveStandardFrame(ui::Window* window); 82 bool ShouldRemoveStandardFrame(ui::Window* window);
83 83
84 // See description of |WindowManager::kRendererParentTitleArea_Property|. 84 // See description of |WindowManager::kRendererParentTitleArea_Property|.
85 bool ShouldRenderParentTitleArea(ui::Window* window); 85 bool ShouldRenderParentTitleArea(ui::Window* window);
86 86
87 // Returns the kInitialDisplayId_Property if present, otherwise 87 // Returns the kInitialDisplayId_Property if present, otherwise
88 // kInvalidDisplayID. 88 // kInvalidDisplayID.
89 int64_t GetInitialDisplayId(const ui::Window::SharedProperties& properties); 89 int64_t GetInitialDisplayId(const ui::Window::SharedProperties& properties);
90 90
91 // Manipulates the kExcludeFromMru_Property property.
msw 2016/10/11 22:36:05 optional nit: combine comments, remove blank line
sky 2016/10/11 22:57:05 I like keeping separate as that way the comments a
92 void SetExcludeFromMru(ui::Window* window, bool value);
msw 2016/10/11 22:36:05 aside: it'd be nice if these were in a window_prop
sky 2016/10/11 22:57:05 How come? Generally we don't use namespaces based
93
94 // Returns true if the property is set and true, otherwise false.
95 bool GetExcludeFromMru(const ui::Window* window);
msw 2016/10/11 22:36:05 very optional nit: IsExcludedFromMru? (like Is* bo
sky 2016/10/11 22:57:05 I went with this to match the name of the property
96
91 } // namespace mus 97 } // namespace mus
92 } // namespace ash 98 } // namespace ash
93 99
94 #endif // ASH_MUS_PROPERTY_UTIL_H_ 100 #endif // ASH_MUS_PROPERTY_UTIL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698