Converts ash/wm/mru_window_tracker_unittest.cc to use AshTest

Converts ash/wm/mru_window_tracker_unittest.cc to use AshTest

And nukes the wm one. I'll move the file to common in a follow on
patch. In order to get this working I needed to add a couple of
things:

. Wire up WmWindowProperty::EXCLUDE_FROM_MRU in WmWindowMus.
. Fix bug in WmShell that resulted in OnWindowActivated() not being
  called correctly (and with wrong args).
. Make ui::WindowObserver::OnWindowDestroyed() be called at the same
  time as that of aura::WindowObserver.

BUG=618058, 654887
TEST=covered by tests
R=msw@chromium.org

Committed: https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1
Cr-Commit-Position: refs/heads/master@{#424603}

[sky, 2016-10-11 21:54:41]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 21:55:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-10-11 22:36:05]

lgtm with nits.

https://codereview.chromium.org/2411913003/diff/20001/ash/mus/property_util.cc
File ash/mus/property_util.cc (right):

https://codereview.chromium.org/2411913003/diff/20001/ash/mus/property_util.c...
ash/mus/property_util.cc:269: window->SetSharedProperty<bool>(
aside: it'd be nice to have something like
ui::Window::[Get|Set]Bool[Shared]Property or similar helpers.

https://codereview.chromium.org/2411913003/diff/20001/ash/mus/property_util.h
File ash/mus/property_util.h (right):

https://codereview.chromium.org/2411913003/diff/20001/ash/mus/property_util.h...
ash/mus/property_util.h:91: // Manipulates the kExcludeFromMru_Property
property.
optional nit: combine comments, remove blank line between.

https://codereview.chromium.org/2411913003/diff/20001/ash/mus/property_util.h...
ash/mus/property_util.h:92: void SetExcludeFromMru(ui::Window* window, bool
value);
aside: it'd be nice if these were in a window_properties namespace or similar.

https://codereview.chromium.org/2411913003/diff/20001/ash/mus/property_util.h...
ash/mus/property_util.h:95: bool GetExcludeFromMru(const ui::Window* window);
very optional nit: IsExcludedFromMru? (like Is* bool getters above).

https://codereview.chromium.org/2411913003/diff/20001/ash/wm/mru_window_track...
File ash/wm/mru_window_tracker_unittest.cc (right):

https://codereview.chromium.org/2411913003/diff/20001/ash/wm/mru_window_track...
ash/wm/mru_window_tracker_unittest.cc:36: WmWindow* w1 = w1_owner->window();
optional nit: inline two |w1_owner->window()| calls; ditto for others.

https://codereview.chromium.org/2411913003/diff/20001/services/ui/public/inte...
File services/ui/public/interfaces/window_manager.mojom (right):

https://codereview.chromium.org/2411913003/diff/20001/services/ui/public/inte...
services/ui/public/interfaces/window_manager.mojom:34: // Type: bool.
optional nit: put on line above.

[sky, 2016-10-11 22:55:46]

Description was changed from

==========
Converts ash/wm/mru_window_tracker_unittest.cc to use AshTest

And nukes the wm one. I'll move the file to common in a follow on
patch. In order to get this working I needed to add a couple of
things:

. Wire up WmWindowProperty::EXCLUDE_FROM_MRU in WmWindowMus.
. Fix bug in WmShell that resulted in OnWindowActivated() not being
  called correctly (and with wrong args).
. Make ui::WindowObserver::OnWindowDestroyed() be called at the same
  time as that of aura::WindowObserver.

BUG=618058, 654887
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Converts ash/wm/mru_window_tracker_unittest.cc to use AshTest

And nukes the wm one. I'll move the file to common in a follow on
patch. In order to get this working I needed to add a couple of
things:

. Wire up WmWindowProperty::EXCLUDE_FROM_MRU in WmWindowMus.
. Fix bug in WmShell that resulted in OnWindowActivated() not being
  called correctly (and with wrong args).
. Make ui::WindowObserver::OnWindowDestroyed() be called at the same
  time as that of aura::WindowObserver.

BUG=618058, 654887
TEST=covered by tests
R=msw@chromium.org
==========

[sky, 2016-10-11 22:55:46]

sky@chromium.org changed reviewers:
+ tsepez@chromium.org

[commit-bot: I haz the power, 2016-10-11 22:56:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 22:56:18]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-11 22:57:05]

+tsepez for mojom change

https://codereview.chromium.org/2411913003/diff/20001/ash/mus/property_util.cc
File ash/mus/property_util.cc (right):

https://codereview.chromium.org/2411913003/diff/20001/ash/mus/property_util.c...
ash/mus/property_util.cc:269: window->SetSharedProperty<bool>(
On 2016/10/11 22:36:05, msw wrote:
> aside: it'd be nice to have something like
> ui::Window::[Get|Set]Bool[Shared]Property or similar helpers.

I think the way we set shared properties is too verbose, and we need a better
more type safe way to do it.

https://codereview.chromium.org/2411913003/diff/20001/ash/mus/property_util.h
File ash/mus/property_util.h (right):

https://codereview.chromium.org/2411913003/diff/20001/ash/mus/property_util.h...
ash/mus/property_util.h:91: // Manipulates the kExcludeFromMru_Property
property.
On 2016/10/11 22:36:05, msw wrote:
> optional nit: combine comments, remove blank line between.

I like keeping separate as that way the comments are more focused.

https://codereview.chromium.org/2411913003/diff/20001/ash/mus/property_util.h...
ash/mus/property_util.h:92: void SetExcludeFromMru(ui::Window* window, bool
value);
On 2016/10/11 22:36:05, msw wrote:
> aside: it'd be nice if these were in a window_properties namespace or similar.

How come? Generally we don't use namespaces based on files, but we've definitely
waffled on that.

https://codereview.chromium.org/2411913003/diff/20001/ash/mus/property_util.h...
ash/mus/property_util.h:95: bool GetExcludeFromMru(const ui::Window* window);
On 2016/10/11 22:36:05, msw wrote:
> very optional nit: IsExcludedFromMru? (like Is* bool getters above).

I went with this to match the name of the property (both mus and ash one).

https://codereview.chromium.org/2411913003/diff/20001/ash/wm/mru_window_track...
File ash/wm/mru_window_tracker_unittest.cc (right):

https://codereview.chromium.org/2411913003/diff/20001/ash/wm/mru_window_track...
ash/wm/mru_window_tracker_unittest.cc:36: WmWindow* w1 = w1_owner->window();
On 2016/10/11 22:36:05, msw wrote:
> optional nit: inline two |w1_owner->window()| calls; ditto for others.

I'm leaving it as in other reviews James favors this style. It's hard to make
everyone happy;)

https://codereview.chromium.org/2411913003/diff/20001/services/ui/public/inte...
File services/ui/public/interfaces/window_manager.mojom (right):

https://codereview.chromium.org/2411913003/diff/20001/services/ui/public/inte...
services/ui/public/interfaces/window_manager.mojom:34: // Type: bool.
On 2016/10/11 22:36:05, msw wrote:
> optional nit: put on line above.

Done.

[sky, 2016-10-11 22:57:15]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 22:57:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 23:08:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 23:08:41]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Tom Sepez, 2016-10-11 23:15:54]

lgtm

[sky, 2016-10-11 23:16:52]

The CQ bit was checked by sky@chromium.org

[sky, 2016-10-11 23:16:52]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2411913003/#ps40001
(title: "comment")

[commit-bot: I haz the power, 2016-10-11 23:17:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 23:55:04]

Description was changed from

==========
Converts ash/wm/mru_window_tracker_unittest.cc to use AshTest

And nukes the wm one. I'll move the file to common in a follow on
patch. In order to get this working I needed to add a couple of
things:

. Wire up WmWindowProperty::EXCLUDE_FROM_MRU in WmWindowMus.
. Fix bug in WmShell that resulted in OnWindowActivated() not being
  called correctly (and with wrong args).
. Make ui::WindowObserver::OnWindowDestroyed() be called at the same
  time as that of aura::WindowObserver.

BUG=618058, 654887
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Converts ash/wm/mru_window_tracker_unittest.cc to use AshTest

And nukes the wm one. I'll move the file to common in a follow on
patch. In order to get this working I needed to add a couple of
things:

. Wire up WmWindowProperty::EXCLUDE_FROM_MRU in WmWindowMus.
. Fix bug in WmShell that resulted in OnWindowActivated() not being
  called correctly (and with wrong args).
. Make ui::WindowObserver::OnWindowDestroyed() be called at the same
  time as that of aura::WindowObserver.

BUG=618058, 654887
TEST=covered by tests
R=msw@chromium.org
==========

[commit-bot: I haz the power, 2016-10-11 23:55:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-12 00:02:44]

Description was changed from

==========
Converts ash/wm/mru_window_tracker_unittest.cc to use AshTest

And nukes the wm one. I'll move the file to common in a follow on
patch. In order to get this working I needed to add a couple of
things:

. Wire up WmWindowProperty::EXCLUDE_FROM_MRU in WmWindowMus.
. Fix bug in WmShell that resulted in OnWindowActivated() not being
  called correctly (and with wrong args).
. Make ui::WindowObserver::OnWindowDestroyed() be called at the same
  time as that of aura::WindowObserver.

BUG=618058, 654887
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Converts ash/wm/mru_window_tracker_unittest.cc to use AshTest

And nukes the wm one. I'll move the file to common in a follow on
patch. In order to get this working I needed to add a couple of
things:

. Wire up WmWindowProperty::EXCLUDE_FROM_MRU in WmWindowMus.
. Fix bug in WmShell that resulted in OnWindowActivated() not being
  called correctly (and with wrong args).
. Make ui::WindowObserver::OnWindowDestroyed() be called at the same
  time as that of aura::WindowObserver.

BUG=618058, 654887
TEST=covered by tests
R=msw@chromium.org

Committed: https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1
Cr-Commit-Position: refs/heads/master@{#424603}
==========

[commit-bot: I haz the power, 2016-10-12 00:02:45]

Patchset 3 (id:??) landed as
https://crrev.com/829e1b23a8e607028515ccf5376314b4d203bcc1
Cr-Commit-Position: refs/heads/master@{#424603}