Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: chrome/browser/resources/inline_login/inline_login.js

Issue 2411883002: Don't record Signin_Signin_From* user actions for re-auth, unlock and adding secondary account (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/inline_login/inline_login.js
diff --git a/chrome/browser/resources/inline_login/inline_login.js b/chrome/browser/resources/inline_login/inline_login.js
index 7e67cbc0728852047a8a40cad9adce1a26eb2ece..17f1c433863169c72c63ec7d6a5fc1c58251ccae 100644
--- a/chrome/browser/resources/inline_login/inline_login.js
+++ b/chrome/browser/resources/inline_login/inline_login.js
@@ -20,6 +20,11 @@ cr.define('inline.login', function() {
*/
var authReadyFired;
+ /**
+ * Whether the login UI is loaded for signing in primary account.
+ */
+ var isLoginPrimaryAccount;
+
function onResize(e) {
chrome.send('switchToFullTab', [e.detail]);
}
@@ -27,7 +32,8 @@ cr.define('inline.login', function() {
function onAuthReady(e) {
$('contents').classList.toggle('loading', false);
authReadyFired = true;
- chrome.send('metricsHandler:recordAction', ['Signin_SigninPage_Shown']);
+ if (isLoginPrimaryAccount)
+ chrome.send('metricsHandler:recordAction', ['Signin_SigninPage_Shown']);
}
function onDropLink(e) {
@@ -74,6 +80,7 @@ cr.define('inline.login', function() {
$('contents').classList.toggle('loading',
data.authMode != cr.login.GaiaAuthHost.AuthMode.DESKTOP ||
data.constrained == '1');
+ isLoginPrimaryAccount = data.isLoginPrimaryAccount;
}
/**

Powered by Google App Engine
This is Rietveld 408576698