src/full-codegen/arm/full-codegen-arm.cc - Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores (Closed)

Patch Set: Move logic to scope analysis time Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/arm/full-codegen-arm.cc

diff --git a/src/full-codegen/arm/full-codegen-arm.cc b/src/full-codegen/arm/full-codegen-arm.cc

index a30ca989ab52cec5009a7a0f06e61620ebeb88fd..30a918af4bd7536ae0e0375d564e1edbc50ccd71 100644

--- a/src/full-codegen/arm/full-codegen-arm.cc

+++ b/src/full-codegen/arm/full-codegen-arm.cc

@@ -1287,7 +1287,7 @@ void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy,

DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode);

Comment cmnt(masm_, var->IsContextSlot() ? "[ Context variable"

: "[ Stack variable");

- if (NeedsHoleCheckForLoad(proxy)) {

+ if (proxy->needs_hole_check()) {

// Throw a reference error when using an uninitialized let/const

// binding in harmony mode.

Label done;