Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 24118003: Pass isolate to v8::Undefined() function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/deprecated_code_generator_v8.pm
diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm
index e1973715d34cacf44cc6ff67d877bb026f173504..0925de2088c1929736684a438c46445aa6e80c1e 100644
--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm
+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm
@@ -1508,7 +1508,7 @@ END
if (ExtendedAttributeContains($attribute->extendedAttributes->{"CallWith"}, "ScriptState")) {
$code .= " if (state.hadException()) {\n";
- $code .= " throwError(state.exception());\n";
+ $code .= " throwError(state.exception(), info.GetIsolate());\n";
$code .= " return;\n";
$code .= " }\n";
}
@@ -1943,7 +1943,7 @@ END
if (ExtendedAttributeContains($attribute->extendedAttributes->{"CallWith"}, "ScriptState")) {
$code .= " if (state.hadException())\n";
- $code .= " throwError(state.exception());\n";
+ $code .= " throwError(state.exception(), info.GetIsolate());\n";
}
if ($svgNativeType) {
@@ -4931,7 +4931,7 @@ sub GenerateFunctionCallString
$code .= $indent . "if (state.hadException()) {\n";
$code .= $indent . " v8::Local<v8::Value> exception = state.exception();\n";
$code .= $indent . " state.clearException();\n";
- $code .= $indent . " throwError(exception);\n";
+ $code .= $indent . " throwError(exception, args.GetIsolate());\n";
$code .= $indent . " return;\n";
$code .= $indent . "}\n";
}
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698