Get gradient information for gpu effect directly from SkGradientShader instead of calling asAGradie…

Get gradient information for gpu effect directly from SkGradientShader instead of calling asAGradient

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14254

[bsalomon, 2014-04-17 19:23:34]

https://codereview.chromium.org/241173005/diff/1/src/effects/gradients/SkGrad...
File src/effects/gradients/SkGradientShaderPriv.h (right):

https://codereview.chromium.org/241173005/diff/1/src/effects/gradients/SkGrad...
src/effects/gradients/SkGradientShaderPriv.h:102: struct DescriptorGpu {
How about we move the logic about whether it is a 2 or 3 color special case into
this new function so we don't have to return a t value and all the colors all
the time.

enum GpuColorType { ... } // moved from GrGradientEffect to SkGradientShader
struct GpuGradientDesc {
    GpuColorType fType;
    SkColor      fColors[3]; // only valid when fType is kTwo or kThree
    bool         fPremulAfterInterp;
    TileMode     fTileMode;
}

[egdaniel, 2014-04-17 20:40:00]

No weird awkward descriptor

[bsalomon, 2014-04-17 20:43:40]

lgtm with some naming suggestions.

https://codereview.chromium.org/241173005/diff/40001/src/effects/gradients/Sk...
File src/effects/gradients/SkGradientShaderPriv.h (right):

https://codereview.chromium.org/241173005/diff/40001/src/effects/gradients/Sk...
src/effects/gradients/SkGradientShaderPriv.h:188: enum ColorType {
Since this is a GPU notion in a non-GPU-specific class let's call it
GpuColorType (and _GpuColorType).

https://codereview.chromium.org/241173005/diff/40001/src/effects/gradients/Sk...
src/effects/gradients/SkGradientShaderPriv.h:194: // Determines and returns the
gradient is a two color gradient, three color gradient
*symmetric* three color?

https://codereview.chromium.org/241173005/diff/40001/src/effects/gradients/Sk...
src/effects/gradients/SkGradientShaderPriv.h:197: ColorType
getGradientColorType(SkColor colors[3]) const;
getGpuColorType()?

https://codereview.chromium.org/241173005/diff/40001/src/effects/gradients/Sk...
src/effects/gradients/SkGradientShaderPriv.h:199: uint32_t getGradientFlags()
const { return fGradFlags; }
getFlags()?

[egdaniel, 2014-04-18 14:18:36]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-04-18 14:18:46]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/egdaniel@google.com/241173005/100001

[commit-bot: I haz the power, 2014-04-18 14:42:16]

Change committed as 14254

[Dominik Grewe, 2014-04-22 10:19:33]

https://codereview.chromium.org/241173005/diff/100001/src/effects/gradients/S...
File src/effects/gradients/SkGradientShaderPriv.h (right):

https://codereview.chromium.org/241173005/diff/100001/src/effects/gradients/S...
src/effects/gradients/SkGradientShaderPriv.h:142: uint32_t getFlags() const {
return fGradFlags; }
I don't think getFlags is a good name if we already have a virtual (non-const)
getFlags  above. Maybe getGradientFlags was better?

[bsalomon, 2014-04-22 13:14:51]

https://codereview.chromium.org/241173005/diff/100001/src/effects/gradients/S...
File src/effects/gradients/SkGradientShaderPriv.h (right):

https://codereview.chromium.org/241173005/diff/100001/src/effects/gradients/S...
src/effects/gradients/SkGradientShaderPriv.h:142: uint32_t getFlags() const {
return fGradFlags; }
On 2014/04/22 10:19:33, Dominik Grewe wrote:
> I don't think getFlags is a good name if we already have a virtual (non-const)
> getFlags  above. Maybe getGradientFlags was better?

Good point... I didn't notice the other getFlags().