third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl - Issue 2411703004: Add usage counter to OffscreenCanvas API calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

Issue 2411703004: Add usage counter to OffscreenCanvas API calls (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.idl ('K') | « third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

index 2e4f8866569e74542622a727c559f496a7790c77..142de7f365dfe434b6b402dc2dabe0337a9c2ce7 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

@@ -706,5 +706,5 @@ typedef unrestricted float GLclampf;

void viewport(GLint x, GLint y, GLsizei width, GLsizei height);

- [RuntimeEnabled=ExperimentalCanvasFeatures, RaisesException] void commit();

+ [RuntimeEnabled=ExperimentalCanvasFeatures, RaisesException, MeasureAs=OffscreenCanvasCommit] void commit();

Justin Novosad 2016/10/13 00:33:46 I think you should use separate counters for 2D an

};