Add usage counter to OffscreenCanvas API calls

Add usage counter to OffscreenCanvas API calls

Currently, there are two important API calls for OffscreenCanvas, which
are transferToImageBitmap and commit. This CL adds usage counter to these
two API calls.

BUG=653599
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/fea82c134538247be328be35fb64d4c69e38c440
Cr-Commit-Position: refs/heads/master@{#427265}

[xidachen, 2016-10-12 13:52:05]

Description was changed from

==========
Add usage counter to OffscreenCanvas API calls

Currently, there are two important API calls for OffscreenCanvas, which
are transferToImageBitmap and commit. This CL adds usage counter to these
two API calls.

BUG=653599
==========

to

==========
Add usage counter to OffscreenCanvas API calls

Currently, there are two important API calls for OffscreenCanvas, which
are transferToImageBitmap and commit. This CL adds usage counter to these
two API calls.

BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xidachen, 2016-10-12 13:53:02]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org, jwd@chromium.org, kbr@chromium.org, zmo@chromium.org

[xidachen, 2016-10-12 13:53:02]

PTAL

[Justin Novosad, 2016-10-13 00:33:46]

https://codereview.chromium.org/2411703004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.idl (right):

https://codereview.chromium.org/2411703004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.idl:14:
[RaisesException, MeasureAs=OffscreenCanvasTransferToImageBitmap] ImageBitmap
transferToImageBitmap();
You should put the counter instrumentation in C++ instead of IDL in order to
count the WebGL and 2D cases separatelyshould

https://codereview.chromium.org/2411703004/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl
(right):

https://codereview.chromium.org/2411703004/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl:709:
[RuntimeEnabled=ExperimentalCanvasFeatures, RaisesException,
MeasureAs=OffscreenCanvasCommit] void commit();
I think you should use separate counters for 2D and WebGL

[jwd, 2016-10-14 15:13:40]

histograms lgtm

[Ken Russell (switch to Gerrit), 2016-10-20 03:48:21]

I defer to junov's review.

[xidachen, 2016-10-20 16:48:39]

PTAL.

[Justin Novosad, 2016-10-24 17:48:33]

On 2016/10/20 16:48:39, xidachen wrote:
> PTAL.

lgtm

[xidachen, 2016-10-25 01:32:33]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 01:33:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xidachen, 2016-10-25 01:33:07]

Description was changed from

==========
Add usage counter to OffscreenCanvas API calls

Currently, there are two important API calls for OffscreenCanvas, which
are transferToImageBitmap and commit. This CL adds usage counter to these
two API calls.

BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Add usage counter to OffscreenCanvas API calls

Currently, there are two important API calls for OffscreenCanvas, which
are transferToImageBitmap and commit. This CL adds usage counter to these
two API calls.

BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xidachen, 2016-10-25 01:33:07]

xidachen@chromium.org changed reviewers:
- kbr@chromium.org, zmo@chromium.org

[xidachen, 2016-10-25 01:33:22]

Description was changed from

==========
Add usage counter to OffscreenCanvas API calls

Currently, there are two important API calls for OffscreenCanvas, which
are transferToImageBitmap and commit. This CL adds usage counter to these
two API calls.

BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Add usage counter to OffscreenCanvas API calls

Currently, there are two important API calls for OffscreenCanvas, which
are transferToImageBitmap and commit. This CL adds usage counter to these
two API calls.

BUG=653599
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xidachen, 2016-10-25 01:34:18]

The CQ bit was unchecked by xidachen@chromium.org

[xidachen, 2016-10-25 01:41:03]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 01:41:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xidachen, 2016-10-25 02:03:16]

The CQ bit was unchecked by xidachen@chromium.org

[xidachen, 2016-10-25 02:04:03]

The CQ bit was checked by xidachen@chromium.org

[xidachen, 2016-10-25 02:04:03]

The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org,
junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2411703004/#ps60001
(title: "fix compile error")

[commit-bot: I haz the power, 2016-10-25 02:04:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 03:38:26]

Description was changed from

==========
Add usage counter to OffscreenCanvas API calls

Currently, there are two important API calls for OffscreenCanvas, which
are transferToImageBitmap and commit. This CL adds usage counter to these
two API calls.

BUG=653599
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Add usage counter to OffscreenCanvas API calls

Currently, there are two important API calls for OffscreenCanvas, which
are transferToImageBitmap and commit. This CL adds usage counter to these
two API calls.

BUG=653599
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-25 03:38:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-25 03:42:10]

Description was changed from

==========
Add usage counter to OffscreenCanvas API calls

Currently, there are two important API calls for OffscreenCanvas, which
are transferToImageBitmap and commit. This CL adds usage counter to these
two API calls.

BUG=653599
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Add usage counter to OffscreenCanvas API calls

Currently, there are two important API calls for OffscreenCanvas, which
are transferToImageBitmap and commit. This CL adds usage counter to these
two API calls.

BUG=653599
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/fea82c134538247be328be35fb64d4c69e38c440
Cr-Commit-Position: refs/heads/master@{#427265}
==========

[commit-bot: I haz the power, 2016-10-25 03:42:11]

Patchset 4 (id:??) landed as
https://crrev.com/fea82c134538247be328be35fb64d4c69e38c440
Cr-Commit-Position: refs/heads/master@{#427265}