Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2411703002: [turbofan] Optimize typeof operator without storing strings in Type (Closed)

Created:
4 years, 2 months ago by mvstanton
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize typeof operator without storing strings in Type We'll take expressions like typeof 'hello' and reduce it to 'string'. Neat! This CL moves the optimization to an explicit reduction in typed lowering that inserts a constant string, instead of relying on type matching. BUG= Committed: https://crrev.com/cacb44a92748c14d63125c2e3203534176db20bc Cr-Commit-Position: refs/heads/master@{#40175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -30 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +1 line, -30 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mvstanton
Hi Jaro, This is similar to the previous CL, can you have a look? Thanks! ...
4 years, 2 months ago (2016-10-11 14:07:41 UTC) #4
Jarin
lgtm. Nice cleanup!
4 years, 2 months ago (2016-10-11 14:14:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411703002/1
4 years, 2 months ago (2016-10-11 14:27:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 14:32:35 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 14:32:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cacb44a92748c14d63125c2e3203534176db20bc
Cr-Commit-Position: refs/heads/master@{#40175}

Powered by Google App Engine
This is Rietveld 408576698