[turbofan] Optimize typeof operator without storing strings in Type

src/compiler/typer.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/typer.h"
 
 #include <iomanip>
 
 #include "src/base/flags.h"
 #include "src/bootstrapper.h"
@@ skipping 272 matching lines @@
   static Type* ObjectIsSmi(Type*, Typer*);
   static Type* ObjectIsString(Type*, Typer*);
   static Type* ObjectIsUndetectable(Type*, Typer*);
 
   static ComparisonOutcome JSCompareTyper(Type*, Type*, Typer*);
 
 #define DECLARE_METHOD(x) static Type* x##Typer(Type*, Type*, Typer*);
   JS_SIMPLE_BINOP_LIST(DECLARE_METHOD)
 #undef DECLARE_METHOD
 
-  static Type* JSTypeOfTyper(Type*, Typer*);
   static Type* JSCallFunctionTyper(Type*, Typer*);
 
   static Type* ReferenceEqualTyper(Type*, Type*, Typer*);
   static Type* StringFromCharCodeTyper(Type*, Typer*);
   static Type* StringFromCodePointTyper(Type*, Typer*);
 
   Reduction UpdateType(Node* node, Type* current) {
     if (NodeProperties::IsTyped(node)) {
       // Widen the type of a previously typed node.
       Type* previous = NodeProperties::GetType(node);
@@ skipping 702 matching lines @@
 }
 
 Type* Typer::Visitor::JSModulusTyper(Type* lhs, Type* rhs, Typer* t) {
   return NumberModulus(ToNumber(lhs, t), ToNumber(rhs, t), t);
 }
 
 
 // JS unary operators.
 
 
-Type* Typer::Visitor::JSTypeOfTyper(Type* type, Typer* t) {
-  Factory* const f = t->isolate()->factory();
-  if (type->Is(Type::Boolean())) {
-    return Type::HeapConstant(f->boolean_string(), t->zone());
-  } else if (type->Is(Type::Number())) {
-    return Type::HeapConstant(f->number_string(), t->zone());
-  } else if (type->Is(Type::String())) {
-    return Type::HeapConstant(f->string_string(), t->zone());
-  } else if (type->Is(Type::Symbol())) {
-    return Type::HeapConstant(f->symbol_string(), t->zone());
-  } else if (type->Is(Type::Union(Type::Undefined(), Type::OtherUndetectable(),
-                                  t->zone()))) {
-    return Type::HeapConstant(f->undefined_string(), t->zone());
-  } else if (type->Is(Type::Null())) {
-    return Type::HeapConstant(f->object_string(), t->zone());
-  } else if (type->Is(Type::Function())) {
-    return Type::HeapConstant(f->function_string(), t->zone());
-  } else if (type->IsHeapConstant()) {
-    return Type::HeapConstant(
-        Object::TypeOf(t->isolate(), type->AsHeapConstant()->Value()),
-        t->zone());
-  } else if (type->IsOtherNumberConstant()) {
-    return Type::HeapConstant(f->number_string(), t->zone());
-  }
+Type* Typer::Visitor::TypeJSTypeOf(Node* node) {
   return Type::InternalizedString();
 }
 
 
-Type* Typer::Visitor::TypeJSTypeOf(Node* node) {
-  return TypeUnaryOp(node, JSTypeOfTyper);
-}
-
-
 // JS conversion operators.
 
 
 Type* Typer::Visitor::TypeJSToBoolean(Node* node) {
   return TypeUnaryOp(node, ToBoolean);
 }
 
 Type* Typer::Visitor::TypeJSToInteger(Node* node) {
   return TypeUnaryOp(node, ToInteger);
 }
@@ skipping 691 matching lines @@
 Type* Typer::Visitor::TypeConstant(Handle<Object> value) {
   if (Type::IsInteger(*value)) {
     return Type::Range(value->Number(), value->Number(), zone());
   }
   return Type::NewConstant(value, zone());
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8