Update DesktopCanvas to allow over-panning when Soft Input Method is present.

Update DesktopCanvas to allow over-panning when Soft Input Method is present.

My previous change allowed the user to 'over-pan' the desktop image such
that it can be pulled out from under any System UI present.  After using
the feature a bit and tqalking with other folks on the team, I think
this behavior should be restricted to only be allowed when a Soft Input
Method is present.

BUG=654565
Committed: https://crrev.com/99f909132e4756059b6414b723beadd72453a71c
Cr-Commit-Position: refs/heads/master@{#424506}

[joedow, 2016-10-10 22:14:37]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 22:14:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 22:23:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 22:23:49]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-10-11 16:45:08]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 16:45:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 16:54:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 16:54:20]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-10-11 17:07:05]

joedow@chromium.org changed reviewers:
+ lambroslambrou@chromium.org, yuweih@chromium.org

[joedow, 2016-10-11 17:07:06]

PTAL!!

[Yuwei, 2016-10-11 18:57:38]

https://codereview.chromium.org/2411503002/diff/20001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
(right):

https://codereview.chromium.org/2411503002/diff/20001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:133: if
(parameter.softInputMethodVisible) {
IIUC change of soft keyboard's visibility will always trigger a
SystemUiVisibilityChanged event, right?

https://codereview.chromium.org/2411503002/diff/20001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:133: if
(parameter.softInputMethodVisible) {
I think you also mentioned that you want to make over-panning always enabled in
multi-window mode. Is this something you want to do later?

[joedow, 2016-10-11 19:00:45]

https://codereview.chromium.org/2411503002/diff/20001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
(right):

https://codereview.chromium.org/2411503002/diff/20001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:133: if
(parameter.softInputMethodVisible) {
On 2016/10/11 18:57:37, Yuwei wrote:
> I think you also mentioned that you want to make over-panning always enabled
in
> multi-window mode. Is this something you want to do later?

Definitely later, we cannot compile against the N SDK yet.

https://codereview.chromium.org/2411503002/diff/20001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:133: if
(parameter.softInputMethodVisible) {
On 2016/10/11 18:57:37, Yuwei wrote:
> IIUC change of soft keyboard's visibility will always trigger a
> SystemUiVisibilityChanged event, right?

Yes it will.

[Yuwei, 2016-10-11 19:01:56]

LGTM

[joedow, 2016-10-11 19:04:09]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-10-11 19:04:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 19:12:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-11 19:15:53]

Description was changed from

==========
Update DesktopCanvas to allow over-panning when Soft Input Method is present.

My previous change allowed the user to 'over-pan' the desktop image such
that it can be pulled out from under any System UI present.  After using
the feature a bit and tqalking with other folks on the team, I think
this behavior should be restricted to only be allowed when a Soft Input
Method is present.

BUG=654565
==========

to

==========
Update DesktopCanvas to allow over-panning when Soft Input Method is present.

My previous change allowed the user to 'over-pan' the desktop image such
that it can be pulled out from under any System UI present.  After using
the feature a bit and tqalking with other folks on the team, I think
this behavior should be restricted to only be allowed when a Soft Input
Method is present.

BUG=654565

Committed: https://crrev.com/99f909132e4756059b6414b723beadd72453a71c
Cr-Commit-Position: refs/heads/master@{#424506}
==========

[commit-bot: I haz the power, 2016-10-11 19:15:54]

Patchset 2 (id:??) landed as
https://crrev.com/99f909132e4756059b6414b723beadd72453a71c
Cr-Commit-Position: refs/heads/master@{#424506}