Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java

Issue 2411503002: Update DesktopCanvas to allow over-panning when Soft Input Method is present. (Closed)
Patch Set: Merging with ToT Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java b/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
index ec6a46774ecfa0d1486b4438fa053fd6f98c9e7d..e93364f249bf980843f5ad4556cb0376ba473eeb 100644
--- a/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
+++ b/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
@@ -130,7 +130,7 @@ public class DesktopCanvas {
* @param parameter The set of values defining the current System UI state.
*/
public void onSystemUiVisibilityChanged(SystemUiVisibilityChangedEventParameter parameter) {
- if (parameter.systemUiVisible) {
+ if (parameter.softInputMethodVisible) {
Yuwei 2016/10/11 18:57:37 I think you also mentioned that you want to make o
Yuwei 2016/10/11 18:57:37 IIUC change of soft keyboard's visibility will alw
joedow 2016/10/11 19:00:44 Definitely later, we cannot compile against the N
joedow 2016/10/11 19:00:44 Yes it will.
mSystemUiScreenSize.set(parameter.left, parameter.top,
mRenderData.screenWidth - parameter.right,
mRenderData.screenHeight - parameter.bottom);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698